Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Antagonist: The Spider Queen #30820

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Dmitry2777
Copy link

About the PR

Queen abilities:

— Laying eggs (4 pieces).
— Summons three small spiders that disappear after 20 seconds.
— Create a wall of web, the web itself and a blue crystal for lighting.

Spiders:

— Spider Queen (the strongest unit, although it is not difficult to kill, so it relies on its children and laid eggs).
— Spider Hunter (the main force of the hive, the best bite).
— Spider Guard (can build walls and webs with crystals).
— Ghost Spider (has invisibility, deals poison damage and injects a sleeping reagent).
— Spider Shooter (shoots poison, hits with poison)

You could say that it will be similar to the Rat King, only the servants will be players. They, as a rule, do not attack themselves, but simply create problems in technical rooms. You can kill one spider with a crowbar, their strength is in the web and unity!

Right now it's not 100% ready, at least the description is normal, the names and distribution into folders are necessary, but the gameplay is all there, so you can take a look and say what to change or something like that.

He appears in the ventilation as the king of rats.

Why / Balance

The new antagonist is fun!

Technical details

Antagonist on 100% prototypes

Media

2024-05-02_20-44-04
2024-08-09_14-24-00
2024-08-09_14-23-41
2024-08-09_14-23-22
2024-08-09_14-23-08
2024-08-09_14-22-51

default.mp4

Requirements

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

  • Um, giant spiders! Who are they and who created them, probably a syndicate... Spiders that are capturing technical rooms with webs, and maybe the entire station, we have problems!

Dmitry2777 and others added 2 commits August 8, 2024 15:27
Queen abilities:

— Laying eggs (4 pieces).
— Summons three small spiders that disappear after 20 seconds.
— Create a wall of web, the web itself and a blue crystal for lighting.

Spiders:

— Spider Queen (the strongest unit, although it is not difficult to kill, so it relies on its children and laid eggs).
— Spider Hunter (the main force of the hive, the best bite).
— Spider Guard (can build walls and webs with crystals).
— Ghost Spider (has invisibility, deals poison damage and injects a sleeping reagent).
— Spider Shooter (shoots poison, hits with poison)

You could say that it will be similar to the Rat King, only the servants will be players. They, as a rule, do not attack themselves, but simply create problems in technical rooms. You can kill one spider with a crowbar, their strength is in the web and unity!

Right now it's not 100% ready, at least the description is normal, the names and distribution into folders are necessary, but the gameplay is all there, so you can take a look and say what to change or something like that.
Antagonist on 100% prototypes
@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Aug 9, 2024
@metalgearsloth
Copy link
Contributor

yargh be needing design doc laddy

@Agustron24
Copy link

You can try to pr this into goob.

@beck-thompson
Copy link
Contributor

beck-thompson commented Aug 9, 2024

Cool idea! I think this would make the spider spawning event a little more interesting. I'm not quite sure how the spawning works (from what I understand it just spawns one queen) but my recommendation would be to have a 50/50 chance to spawn a queen with a few guards or just the the guards by themselves. If you do it this way it will be harder to meta game killing the queen.

Besides that here are a couple other issues:

1.) Make sure to have a design document as (now pirate?) sloth says! Here is how to do that (If you need help just ask in the discord!) https://docs.spacestation14.com/en/general-development/feature-proposals.html
In your doc, make sure to hit on what core pillars your event has.

2.)Your YMAL test failed! Those are the lines that have issues (so far). Github tells you when it fails just click on details for what the issues are!
image
image

3.) You really shouldn't be having one massive file. Split it up into different parts! For example, the spawning event should have its own file, the queen should have its own file (You could probably also add all the stuff directly related to the queen in that file as well like eggs) and all the unique spiders should also have their own file each. If there is some abstract class that you need for multiple, just add like a base_spiders.yml file and add them there!

4.) I think you forgot to change couple Russian names and stuff!
image

There is probably other stuff I missed but doing those is important.
Good luck 🫡

@Dmitry2777
Copy link
Author

Классная идея! Я думаю, это сделало бы событие возрождения пауков немного интереснее. Я не совсем уверен, как работает создание (насколько я понимаю, оно создает только одну королеву), но я бы порекомендовал иметь шанс 50/50 создать королеву с несколькими охранниками или только самих охранников. Если вы сделаете это таким образом, будет сложнее пройти мета-игру, убив королеву.

Помимо этого, есть пара других проблем:

1.) Убедитесь, что у вас есть дизайн-документ, как говорит ленивец (теперь пиратский?)! Вот как это сделать (Если вам нужна помощь, просто спросите в discord!) https://docs.spacestation14.com/en/general-development/feature-proposals.html В своем документе обязательно укажите, какие основные принципы есть у вашего мероприятия.

2.) Ваш тест YMAL не пройден! Это строки, в которых есть проблемы (пока). Github сообщит вам, когда произойдет сбой, просто нажмите на подробную информацию о проблемах! изображение изображение

3.) У вас действительно не должно быть одного большого файла. Разделите его на разные части! Например, у события появления на свет должен быть свой собственный файл, у королевы должен быть свой собственный файл (вероятно, вы могли бы также добавить в этот файл все материалы, непосредственно связанные с королевой, например яйца) и у всех уникальных пауков также должен быть свой собственный файл. Если есть какой-то абстрактный класс, который вам нужен для нескольких, просто добавьте файл like a base_spiders.yml и добавьте их туда!

4.) I think you forgot to change couple Russian names and stuff! image

There is probably other stuff I missed but doing those is important. Good luck 🫡

Yes, I know, well, besides the design, I read a little about them, I'll go to discord to figure out how to do it. I will correct mistakes and improve after verbal approval or something. At least first we need to find out if it is necessary or not.

@Dmitry2777
Copy link
Author

And these spiders do not change tarantulas and tarantulas do not enter the hive.

@whateverusername0
Copy link

we can make this real.

Dmitry2777 added a commit to Dmitry2777/docs that referenced this pull request Aug 10, 2024
@Dmitry2777
Copy link
Author

space-wizards/docs#279

Copy link
Contributor

@NakataRin NakataRin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, please remove any Russian text, including comments, and ensure the file is properly split into smaller, more manageable files. Additionally, since this PR is not yet ready for review, I recommend drafting it until it's fully prepared. I've also pointed out typos and other issues that need attention.

- type: entity
noSpawn: true
name: Probca
id: MobSpiderSpacePueen
Copy link
Contributor

@NakataRin NakataRin Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pueen? Not sure if this is intentional.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will correct it with approval space-wizards/docs#279


- type: entity
id: SpawnPointGhostSpaceQueen
name: спавнер роли королевы-пауков
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Russian, here and through the entire file

interactFailureString: petting-failure-generic
- type: NoSlip
- type: IgnoreSpiderWeb
- type: PassiveDamage # Slight passive regen. Assuming one damage type, comes out to about 4 damage a minute.Самолечение
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Russian, in comments this time. Same for the entire file.

prototypes:
- id: FloorTileItemWebSpiders
amount: 1
useDelay: 25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

state: full
useDelay: 30
event: !type:WorldSpawnSpellEvent
useDelay: 25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing out the errors.

@Agustron24
Copy link

Pueen

@NULL882
Copy link
Contributor

NULL882 commented Aug 12, 2024

He just take this prototype from public Corvax workshop...

https://discord.com/channels/919301044784226385/1234813849870270464/1234813849870270464

@NakataRin
Copy link
Contributor

NakataRin commented Aug 12, 2024

He just take this prototype from public Corvax workshop...

https://discord.com/channels/919301044784226385/1234813849870270464/1234813849870270464

image

Cool link, I guess. Though that would explain russian screenshots

@Dmitry2777
Copy link
Author

Dmitry2777 commented Aug 13, 2024

@Agustron24 @NakataRin
2024-08-13_09-05-45
Well, yes, what's the problem? I created a prototype myself, I put it in the workshop myself.
t's best to verify information before making accusations.

@deathride58 deathride58 added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Aug 19, 2024
@Dmitry2777
Copy link
Author

https://www.youtube.com/watch?v=YAXuM8YKAOM - Spider gameplay. You can see how it looks in practice here. Well, you can also just upload the prototype to the server and test them on your server.

@Dmitry2777
Copy link
Author

These are spiders with translation into Russian, on video.

@Agustron24
Copy link

Mfw i want to play the pr but it never arrives

@HerCoyote23 HerCoyote23 mentioned this pull request Oct 6, 2024
2 tasks
@UBlueberry
Copy link
Contributor

just a week away

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@ScarKy0 ScarKy0 added P1: High Priority: Higher priority than other items, but isn't an emergency. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 18, 2024
@ScarKy0 ScarKy0 added T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. S: Stale Status: Stale with no activity, and may be closed after a week if there is no new activity. A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D2: Medium Difficulty: A good amount of codebase knowledge required. P1: High Priority: Higher priority than other items, but isn't an emergency. S: Stale Status: Stale with no activity, and may be closed after a week if there is no new activity. S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.