Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return deleted lobby music in jukebox #31849

Closed
wants to merge 5 commits into from

Conversation

lzk228
Copy link
Contributor

@lzk228 lzk228 commented Sep 4, 2024

About the PR

taken right from #24480

Why / Balance

more music

Technical details

no

Media

no

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: Added some new old music in jukebox.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Sep 4, 2024
@slarticodefast
Copy link
Member

We still have atomic amnesia as lobby music I think? No need to add the file a second time.

@Doctor-Cpu
Copy link
Contributor

its a good song regardless
we also have tin tin on the moon twice

@slarticodefast
Copy link
Member

slarticodefast commented Sep 4, 2024

Yes, but you can just change the path in yaml to the other folder instead of literally having the same file twice in different folders.

@lzk228
Copy link
Contributor Author

lzk228 commented Sep 4, 2024

@slarticodefast title3 is also dublicated, then should i remove dublication for both amnesia and title3?

@slarticodefast
Copy link
Member

I guess? If it's exactly the same file we can just reuse it to reduce the game's file size. Except if anyone can tell me a reason why we are not doing that.

@Doctor-Cpu
Copy link
Contributor

the jukebox songs are all mono while the lobby are stereo
image

This reverts commit 5438eb6.
@lzk228
Copy link
Contributor Author

lzk228 commented Sep 4, 2024

ok, dupe stays as it is
i tested all ingame and everything works fine

@slarticodefast
Copy link
Member

the jukebox songs are all mono while the lobby are stereo

Ah, that explains it! Make sure the songs you uploaded are mono as well then.

@slarticodefast
Copy link
Member

I checked with the other maintainers and jukebox music is frozen until we implement an audio streaming system (see #8524). We don't want the game's file size to get too big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants