-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return deleted lobby music in jukebox #31849
Conversation
We still have atomic amnesia as lobby music I think? No need to add the file a second time. |
its a good song regardless |
Yes, but you can just change the path in yaml to the other folder instead of literally having the same file twice in different folders. |
@slarticodefast title3 is also dublicated, then should i remove dublication for both amnesia and title3? |
I guess? If it's exactly the same file we can just reuse it to reduce the game's file size. Except if anyone can tell me a reason why we are not doing that. |
This reverts commit 5438eb6.
ok, dupe stays as it is |
Ah, that explains it! Make sure the songs you uploaded are mono as well then. |
I checked with the other maintainers and jukebox music is frozen until we implement an audio streaming system (see #8524). We don't want the game's file size to get too big. |
About the PR
taken right from #24480
Why / Balance
more music
Technical details
no
Media
no
Requirements
Breaking changes
Changelog
🆑