CorporealSystem cleanup + revenant fixes #32541
Open
+59
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlamBamActionman
added
the
S: Untriaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Refactors and cleans up SharedCorporealSystem and CorporealSystem. Fixes #32540.
Why / Balance
bug fix good
Technical details
SharedCorporealSystem
UpdateCollisionOnInitandOnShutdownto protected virtual methods to allow overriding in derived classesCorporealSystem changes
UpdateVisibilityOnInitandOnShutdownmethods to call the base implementation and then handle visibility changes._tickerto_gameTickerRequirements
Breaking changes
hopefully none
Changelog
no cl, no fun