Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the window titlebar to show the joined server #32547

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

VasilisThePikachu
Copy link
Member

@VasilisThePikachu VasilisThePikachu commented Sep 30, 2024

About the PR

The games window title will now update with the hostname of the server. Updates with hostname changes, and can optionally be disabled by the server with the game.hostname_in_titlebar cvar (in case the server updates the manifest.yml to show the server name instead and does not have other server to warent having their server name on the title bar)

Why / Balance

Makes the life of admins who have multiple game server joined easier by being able to find each server from the titlebar

Makes it easier for players to identify what server they joined if they forgot.

Looks cool.

Technical details

Media

image

Requirements

Changelog

🆑 Myra

  • add: The game's title bar window will display the name of the server you have joined (unless disabled).

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Sep 30, 2024
@PJB3005 PJB3005 self-assigned this Oct 12, 2024
Content.Shared/CCVar/CCVars.cs Outdated Show resolved Hide resolved
@VasilisThePikachu
Copy link
Member Author

VasilisThePikachu commented Oct 12, 2024

Tests are failing cause its trying to pull engine changes and it gets a conflict on the release file... even removing it does not help. But i can assure you it works

edit: oh its cause i put it in my commit message :godo:

@PJB3005 PJB3005 merged commit a739b21 into space-wizards:master Oct 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants