-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the window titlebar to show the joined server #32547
Merged
PJB3005
merged 7 commits into
space-wizards:master
from
VasilisThePikachu:hostname-window-title
Oct 17, 2024
Merged
Change the window titlebar to show the joined server #32547
PJB3005
merged 7 commits into
space-wizards:master
from
VasilisThePikachu:hostname-window-title
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S: Needs Review
Status: Requires additional reviews before being fully accepted
label
Sep 30, 2024
PJB3005
requested changes
Oct 12, 2024
PJB3005
requested changes
Oct 12, 2024
…-14 into hostname-window-title
Tests are failing cause its trying to pull engine changes and it gets a conflict on the release file... even removing it does not help. But i can assure you it works edit: oh its cause i put it in my commit message :godo: |
metalgearsloth
approved these changes
Oct 14, 2024
PJB3005
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
The games window title will now update with the hostname of the server. Updates with hostname changes, and can optionally be disabled by the server with the
game.hostname_in_titlebar
cvar (in case the server updates the manifest.yml to show the server name instead and does not have other server to warent having their server name on the title bar)Why / Balance
Makes the life of admins who have multiple game server joined easier by being able to find each server from the titlebar
Makes it easier for players to identify what server they joined if they forgot.
Looks cool.
Technical details
Media
Requirements
Changelog
🆑 Myra