Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two additional checks to prevent FTLing stations #32558

Merged

Conversation

Plykiya
Copy link
Contributor

@Plykiya Plykiya commented Sep 30, 2024

About the PR

Added more safeguards to prevent FTLing when it shouldn't happen

Why / Balance

People have been FTLing stations because the station anchor's changes were not accounted for in the FTL code at the moment and this kind of ruins rounds

Technical details

  1. Station anchors allow FTLing because setting the grid to a static physics body causes it to have 0 mass, the mass check is the only thing stopping stations from FTLing normally
  2. Add a check in the FTL code for the grid being static
  3. Add a check in the FTL code for if the shuttleComp is disabled

Media

Spam clicking FTL

2024-09-30.14-41-27.mp4

Requirements

Breaking changes

nae

Changelog

🆑

  • fix: You can no longer FTL the station.

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Sep 30, 2024
@Plykiya
Copy link
Contributor Author

Plykiya commented Sep 30, 2024

image
tested FTLing with the anchor disabled, works when the grid is small enough

tested FTLing with the anchor enabled, prevents FTLing

@baddiePRO
Copy link

does this break the evac/arrivals shuttle? I've seen people drag the station anchor to the evac shuttle and make it do funky things.

@baddiePRO
Copy link

does this break the evac/arrivals shuttle? I've seen people drag the station anchor to the evac shuttle and make it do funky things.

https://discord.com/channels/310555209753690112/675078881425752124/1288331890171973702

@Plykiya
Copy link
Contributor Author

Plykiya commented Sep 30, 2024

does this break the evac/arrivals shuttle? I've seen people drag the station anchor to the evac shuttle and make it do funky things.

these people should be blown up

@baddiePRO
Copy link

tbf it was pretty funny

@ArtisticRoomba
Copy link
Contributor

Side note that (unless it's already been fixed) you can drag/build a shuttle console on Evac and undock Evac from the station dock preemptively. Saw it happen on salamander.

@Plykiya
Copy link
Contributor Author

Plykiya commented Sep 30, 2024

image

confirmed it doesn't break arrivals
confirmed you can't ftl with arrivals to kidnap it

@Plykiya
Copy link
Contributor Author

Plykiya commented Sep 30, 2024

Side note that (unless it's already been fixed) you can drag/build a shuttle console on Evac and undock Evac from the station dock preemptively. Saw it happen on salamander.

I'm not fixing this but I can confirm it's doable

@WhiteGorila
Copy link

AI law 2 turn the station anchor off

@Golinth
Copy link
Contributor

Golinth commented Oct 4, 2024

AI law 2 turn the station anchor off

Denied, law 1 prevents me from doing so. The station drifting may cause someone to become stranded and be harmed.

@metalgearsloth metalgearsloth merged commit 295e631 into space-wizards:master Oct 4, 2024
13 checks passed
@Plykiya Plykiya deleted the Station-Anchor-FTLless branch October 4, 2024 08:13
Ilya246 pushed a commit to Ilya246/space-station-14 that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants