Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flares and shotgun flares from lathe options #32563

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Plykiya
Copy link
Contributor

@Plykiya Plykiya commented Oct 1, 2024

About the PR

Removes the ability to print flares and boxes of flare shells from the lathes

Why / Balance

People have been spamming them to break the lighting engine

Technical details

Delete the recipe ID from the corresponding lathes

Changelog

🆑

  • remove: You can no longer print flares or shotgun flares.

@github-actions github-actions bot added the No C# For things that don't need code. label Oct 1, 2024
@Plykiya Plykiya changed the title Remove flares and shotgun flares from lathe recipes Remove flares and shotgun flares from lathe options Oct 1, 2024
@baddiePRO
Copy link

this is why we can't have nice things

@WhiteGorila
Copy link

Removing flares is not the solution, removing the ability to stack lights would be better. I don't even use flares but still no reason to remove them from the lathe

@slarticodefast
Copy link
Member

slarticodefast commented Oct 1, 2024

Removing flares is not the solution, removing the ability to stack lights would be better.

That will need a rewrite of the rendering engine. For the former you need 4 lines of yaml, for the latter you need to read scientific papers.

@WhiteGorila
Copy link

Removing flares is not the solution, removing the ability to stack lights would be better.

That will need a rewrite of the rendering engine. For the former you need 4 lines of yaml, for the latter you need to read scientific papers.

Blah blah blahe. I'm talking about people being able to rcd 500 lights on one tile, not rendering. I've never even seen someone stack a bunch of flares before, and even then light stacking isn't even a huge deal. I'd rather a proper fix, or no fix at all over a lazy one, removing items from the game is just lazy. Reminds me of plastic flaps.

@slarticodefast
Copy link
Member

They are not being removed, you can still find them everywhere, like in survival kits, tool boxes and salvage equipment. The only change is that you cannot mass-produce them anymore, like it always was until 2 weeks ago where they were made a lathe recipe.

@superjj18
Copy link
Contributor

They are not being removed, you can still find them everywhere, like in survival kits, tool boxes and salvage equipment. The only change is that you cannot mass-produce them anymore, like it always was until 2 weeks ago where they were made a lathe recipe.

Doesn't change the fact that this is a lazy bandaid solution to a bigger issue

@metalgearsloth
Copy link
Contributor

They are not being removed, you can still find them everywhere, like in survival kits, tool boxes and salvage equipment. The only change is that you cannot mass-produce them anymore, like it always was until 2 weeks ago where they were made a lathe recipe.

Doesn't change the fact that this is a lazy bandaid solution to a bigger issue

Lazy bandaid
Rewriting the entire lighting renderer

Like c'mon mate.

@slarticodefast slarticodefast added the Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# For things that don't need code. Undergoing Maintainer Discussion This PR is currently going through the 72-hour discussion window as per maintainer policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants