Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construction menu grid view #32577

Merged
merged 17 commits into from
Nov 20, 2024

Conversation

qwerltaz
Copy link
Contributor

@qwerltaz qwerltaz commented Oct 1, 2024

About the PR

Add button to construction menu for changing item view to grid. Also resize construction window to be thinner and higher by default, giving view on more items both in normal view and grid view, without sacrificing any part of recipe info on the right.

Good visibility: When selected, the texture of the button goes green for when entity takes up the entire button, and the background goes gray in case of small items.

Why / Balance

A lot more concise, all items are faster to access. It's added as an optional toggleable feature for those who want to use it.

Technical details

new case, if grid view button is pressed, item list is cleared and item grid is populated instead. Grid has buttons that call SelectGridButton to handle UI changes.

Media

2024-10-01_465_Content.Client.mp4

Requirements

Changelog

🆑

  • add: A new grid item view is available in the construction menu, togglable with a button.
  • tweak: Construction menu default window size was tweaked.

@github-actions github-actions bot added the Changes: UI Changes: Might require knowledge of UI design or code. label Oct 1, 2024
@chromiumboy chromiumboy self-assigned this Oct 20, 2024
@chromiumboy
Copy link
Contributor

I like this a lot, nice work

@chromiumboy chromiumboy added the S: Awaiting Changes Status: Changes are required before another review can happen label Oct 20, 2024
Copy link
Contributor

@chromiumboy chromiumboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, only one or two small things to fix

@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Oct 25, 2024
@chromiumboy chromiumboy added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Oct 26, 2024
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@SaphireLattice SaphireLattice added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces A: General Interactions Area: General in-game interactions that don't relate to another area. size/M Denotes a PR that changes 30-99 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 16, 2024
@metalgearsloth metalgearsloth merged commit e98383d into space-wizards:master Nov 20, 2024
12 checks passed
@qwerltaz qwerltaz deleted the build-menu-grid-view branch November 20, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: UI Changes: Might require knowledge of UI design or code. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 30-99 lines. T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants