-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Construction menu grid view #32577
Merged
metalgearsloth
merged 17 commits into
space-wizards:master
from
qwerltaz:build-menu-grid-view
Nov 20, 2024
Merged
Construction menu grid view #32577
metalgearsloth
merged 17 commits into
space-wizards:master
from
qwerltaz:build-menu-grid-view
Nov 20, 2024
+114
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Changes: UI
Changes: Might require knowledge of UI design or code.
label
Oct 1, 2024
chromiumboy
requested changes
Oct 20, 2024
I like this a lot, nice work |
chromiumboy
added
the
S: Awaiting Changes
Status: Changes are required before another review can happen
label
Oct 20, 2024
chromiumboy
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, only one or two small things to fix
github-actions
bot
added
S: Needs Review
Status: Requires additional reviews before being fully accepted
and removed
S: Awaiting Changes
Status: Changes are required before another review can happen
labels
Oct 25, 2024
chromiumboy
added
S: Approved
Status: Reviewed and approved by at least one maintainer; a PR may require another approval.
and removed
S: Needs Review
Status: Requires additional reviews before being fully accepted
labels
Oct 26, 2024
chromiumboy
approved these changes
Oct 26, 2024
SlamBamActionman
added
the
S: Untriaged
Status: Indicates an item has not been triaged and doesn't have appropriate labels.
label
Nov 14, 2024
SaphireLattice
added
P2: Raised
Priority: Item has a raised priority, indicating it might get increased maintainer attention.
S: Needs Review
Status: Requires additional reviews before being fully accepted
T: UI / UX Improvement
Type: UI and player facing interactive graphical interfaces
A: General Interactions
Area: General in-game interactions that don't relate to another area.
size/M
Denotes a PR that changes 30-99 lines.
and removed
S: Untriaged
Status: Indicates an item has not been triaged and doesn't have appropriate labels.
labels
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A: General Interactions
Area: General in-game interactions that don't relate to another area.
Changes: UI
Changes: Might require knowledge of UI design or code.
P2: Raised
Priority: Item has a raised priority, indicating it might get increased maintainer attention.
S: Approved
Status: Reviewed and approved by at least one maintainer; a PR may require another approval.
S: Needs Review
Status: Requires additional reviews before being fully accepted
size/M
Denotes a PR that changes 30-99 lines.
T: UI / UX Improvement
Type: UI and player facing interactive graphical interfaces
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Add button to construction menu for changing item view to grid. Also resize construction window to be thinner and higher by default, giving view on more items both in normal view and grid view, without sacrificing any part of recipe info on the right.
Good visibility: When selected, the texture of the button goes green for when entity takes up the entire button, and the background goes gray in case of small items.
Why / Balance
A lot more concise, all items are faster to access. It's added as an optional toggleable feature for those who want to use it.
Technical details
new case, if grid view button is pressed, item list is cleared and item grid is populated instead. Grid has buttons that call SelectGridButton to handle UI changes.
Media
2024-10-01_465_Content.Client.mp4
Requirements
Changelog
🆑