Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chamomile #32592

Closed
Closed

Conversation

OrangeMoronage9622
Copy link
Contributor

About the PR

Added Chamomile

Why / Balance

Wanted a new tea

Technical details

Added a new reagent and added it to be drank inside the solar hot drinks

Requirements

Breaking changes

All my code that has ever existed, will ever exist and in the future will exist is all garbage.
This will be posted in #codebase-changes. -->

Changelog
🆑

  • add: Added Chamomile

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Oct 2, 2024
@OrangeMoronage9622
Copy link
Contributor Author

Ehh, did it like twice, not sure it's gonna work.

I'm fucking stupid, a typo
I shouldn't be editting on the fly in a PR but it's so small.
@AlexUm418
Copy link
Contributor

Mm chamomile


- type: entity
parent: DrinkBaseCup
id: DrinkHotChamomile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be an idea to create a new base prototypes for teas, since there are now multiple different types with only a few differences between them

- !type:SatiateThirst
factor: 2
- !type:GenericStatusEffect
key: Drowsiness
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in-game and it didn't have any drowsiness effect, likely because the status gets refreshed each time you take a sip. I'd recommend just removing the effect rather than making it work though, easy access to budget chloral hydrate doesn't seem like a good idea

@chromiumboy chromiumboy self-assigned this Oct 20, 2024
@chromiumboy
Copy link
Contributor

Also the choice of color for the reagent makes it very hard to read on inspection

chamolie_tea_inspect

@chromiumboy chromiumboy added the S: Awaiting Changes Status: Changes are required before another review can happen label Oct 20, 2024
@chromiumboy
Copy link
Contributor

Hi, are you coming back to this PR?

@OrangeMoronage9622
Copy link
Contributor Author

Forgot about this. Uhhhh, maybe?

@chromiumboy
Copy link
Contributor

Forgot about this. Uhhhh, maybe?

No worries. If you decide you don't want to come back to this, just let me know, or you can close the PR

@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@chromiumboy
Copy link
Contributor

It doesn't seem like you're currently working on this so I'll close it for now

If you do decide to come back it, feel free to re-open it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Awaiting Changes Status: Changes are required before another review can happen S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants