Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add movement animations to some animals #32607

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ravage123321
Copy link
Contributor

@ravage123321 ravage123321 commented Oct 2, 2024

About the PR

I have added motion animation to the following list of animals:
Walter, Corgi, Ian, Lisa, puppy, Cat, Cat2, kitten, SpaceCat, Syndicat, Cak, Caracal, McGriff, Breaddog

I slightly adjusted the kitten's sprite, because it had a different size in front and back, also removed the orange pixels on the white corgi fur
Renamed the name of the breaddog images to match the rest
(recreated PR because had problems)

The only problem I've encountered is that cats are pets, despite the fact that they have a Parent of ordinary cats and they use their sprites, they don't get animation. I can fix this by just adding a component for them, but I guess I'd better wait for comments, maybe I made a mistake.

Why / Balance

At the moment, the game has motion animations, but a very small list of animals

Media

Dotnet.2024.09.23.-.15.08.15.11.online-video-cutter.com.mp4
Dotnet.2024.09.23.-.19.23.00.25.online-video-cutter.com.mp4

Requirements

Changelog

🆑

  • add: Added movement animation to animals!

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

RSI Diff Bot; head commit 3046666 merging into 440742f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Pets/cat.rsi

State Old New Status
kitten Modified
cak-moving Added
cat-moving Added
cat2-moving Added
kitten-moving Added
spacecat-moving Added
syndicat-moving Added

Resources/Textures/Mobs/Pets/corgi.rsi

State Old New Status
corgi Modified
corgi-moving Added
ian-moving Added
lisa-moving Added
puppy-moving Added

Resources/Textures/Mobs/Pets/breaddog.rsi

State Old New Status
breaddog-moving Added

Resources/Textures/Mobs/Pets/caracal.rsi

State Old New Status
caracal-moving Added

Resources/Textures/Mobs/Pets/mcgriff.rsi

State Old New Status
mcgriff-moving Added

Resources/Textures/Mobs/Pets/walter.rsi

State Old New Status
walter-moving Added

Edit: diff updated after 3046666

@slarticodefast
Copy link
Member

The test fail seems to be real, something is wrong with the .rsi

@ravage123321
Copy link
Contributor Author

The test fail seems to be real, something is wrong with the .rsi

yep, because

Renamed the name of the breaddog images to match the rest

@ravage123321
Copy link
Contributor Author

it's just that all animals (including catcake) have the name of the sprite base from the name of the entity itself, the bread dog is the only one for whom it's just base. But I can remove this

@ravage123321
Copy link
Contributor Author

A breaddog sprites work normally in game

@slarticodefast
Copy link
Member

You still have the old base.png and dead.png files in the breaddog.rsi folder, but removed them from the meta.json, which is causing the error.

@ravage123321
Copy link
Contributor Author

You still have the old base.png and dead.png files in the breaddog.rsi folder, but removed them from the meta.json, which is causing the error.

oh yeah my fault sorry haha

@slarticodefast slarticodefast added the S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. label Oct 18, 2024
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@SaphireLattice SaphireLattice added D3: Low Difficulty: Some codebase knowledge required. A: Art Area: Art with no implications for other areas. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. P: Very Low / Fluff labels Nov 15, 2024
@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Art Area: Art with no implications for other areas. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants