Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box Station - Connected Recycler, rerouted power for Singlo Substation, added law boards to AI upload room #32608

Merged

Conversation

southbridge-fur
Copy link
Contributor

@southbridge-fur southbridge-fur commented Oct 2, 2024

About the PR

Addresses #32443, #30375 and #32581

For #32443

The Recycler just needed to be connected.

For #30375

I realized that the substation powering the PA and Containment field was on the same HV network as the power generation. This mean that if power generation ever stopped, the substation would drain before the station SMESes and could cause a loose.

This changes it to where that substation is now running off of the same HV network as the rest of the station, thereby ensuring that the SMESes are used to power the substation which in turn powers the PA and Containment Field. Most other maps are wired this way.

For #32581

Added the 10 AI lawboards to the AI upload room.

image

From top left going counter-clockwise:

  • NT Default
  • Paladin
  • Ten Commandments
  • Corporate
  • Station Efficiency
  • Left Glass Case: Artist
  • Right Glass Case: Robocop
  • Dungeon Master
  • Crewsimov
  • Nutimov

Why / Balance

Addresses issues with the map.

Technical details

For the substation, I rerouted the power from the TEG through a new reinforced window between the power generation area and the TEG room. I also added a HV cable under the glass going to the PA to link those networks together.

Before

image

After

image

Media

See above.

Requirements

Breaking changes

None that I know of.

Changelog

🆑 Southbridge

  • fix: Box station's recycler has been properly connected.
  • tweak: Box station's singlo substation has been rewired to the station-wide HV network.
  • add: Box station now has AI law boards in the upload room.

@ss14-map-server
Copy link

ss14-map-server bot commented Oct 2, 2024

This PR contains new or changed maps:

Box

image

10/03/24 22:17

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Map Changes: Might require knowledge of mapping. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@southbridge-fur
Copy link
Contributor Author

Will also address #32581 and fix those merge conflicts.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Oct 3, 2024
@Emisse
Copy link
Contributor

Emisse commented Oct 3, 2024

test fail real

@southbridge-fur
Copy link
Contributor Author

I see what's wrong and will fix it

@southbridge-fur southbridge-fur changed the title Box Station - Connected Recycler and rerouted power for Singlo Substation Box Station - Connected Recycler, rerouted power for Singlo Substation, added law boards to AI upload room Oct 3, 2024
@southbridge-fur
Copy link
Contributor Author

Another similar issue, I will fix

@southbridge-fur
Copy link
Contributor Author

Well I can't find where the entity with a uid of 0 is. Not really sure what I need to do to fix this.

@southbridge-fur
Copy link
Contributor Author

Well I can't find where the entity with a uid of 0 is. Not really sure what I need to do to fix this.

Looks like I may have had a UI element open while saving which caused there to be an invalid UID. It's been removed.

@Emisse Emisse merged commit c0d6742 into space-wizards:master Oct 4, 2024
11 checks passed
Ilya246 pushed a commit to Ilya246/space-station-14 that referenced this pull request Oct 7, 2024
…n, added law boards to AI upload room (space-wizards#32608)

* Fixed space-wizards#32443 and space-wizards#30375

* Fixed duplicate ID issue, and added lawboards to resolve space-wizards#32581

* Removed Overlord board and added Crewsimov

* Removed invalid UserInterface component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants