Rework the Flare Gun & add a Security Shell Gun. #32829

BramvanZijp · 2024-10-15T15:02:02Z

About the PR

Several changes were made in this PR:

Rework flare guns, they now work sort of like a pistol except without the magazine. They start closed with a shell loaded in them, then you can fire it. The empty shell does not eject. Then you press E on it to unbolt and open it, which drops the current shell on the ground and allow you to put a new shell inside, then you can close it again to fire again.
Add a security shell gun, which is a resprited flare gun restricted to security, and is craftable in the sec techfab. This is designed to launch beanbag or tranq rounds, though it can also make use of lethal shells in a pinch.
Flare guns are now twice as likely to spawn in emergency lockers.

Why / Balance

A sprite for an opened flare gun has existed in the code, but it is never used. It also just makes sense to have to open it for the old shell to fall out and you to be able to put the new shell back in, this also prevents spam reloading and firing it with the extra added step.

As for the security shell gun, it is craftable in the secfab and designed to be used with beanbag and tranquilizer shells. From my experience these shells, especially tranquilizer, very rarely see use due to the hastle of carrying around the entire shotgun just to use these non-lethal shells and the fact that it would be frowned upon outside alert levels that warrant lethals, at which point you are better off taking lethal shells instead. This would allow security to carry one of these around on lower alert levels and still use the shells.

Technical details

The flare gun now uses the code used by pistols (excluding a magazine) instead of that used by shotguns. Also, improvised, beanbag, tranquilizer and flare rounds now have the ShotgunShellLight, if somebody intends to re-introduce #22349 properly, this can be used for that. (The Security Shell Gun should still be able to fire lethals.)

Media

A video of the regular flare gun with the new bolt mechanics:
https://github.com/user-attachments/assets/00f46007-03b7-4c97-b6ab-a08704112558

The new security shell gun sprites: (Just recolored to be red)

Requirements

I have read and am following the Pull Request and Changelog Guidelines.
I have added media to this PR or it does not require an ingame showcase.

Changelog

🆑 BramvanZijp

tweak: Flare guns have been reworked to no longer automatically eject shells after firing, and must now be opened manually to insert or eject shells. A safety feature has also been added to prevent loading lethal shells into them.
tweak: Flare guns are twice as likely to appear in emergency closets, with the same rarity as MRE's.
add: Added the security shell gun, a modified flare gun which is capable of handling both nonlethal and lethal shotgun shells. It is able to be crafted in the security techfab without needing any research.

… to be able to.

github-actions · 2024-10-15T15:02:41Z

RSI Diff Bot; head commit e6c5405 merging into a0ef431
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Weapons/Guns/Shotguns/flaregun_security.rsi

State	Old	New	Status
base			Added
bolt-open			Added
equipped-BELT			Added
equipped-SUITSTORAGE			Added
inhand-left			Added
inhand-right			Added

Edit: diff updated after e6c5405

…ad of plastic

BramvanZijp · 2024-10-15T17:30:11Z

For the record, later on it may be good to have a system where the plastic flaregun can backfire if using lethal shells, but for now it should probably be disabled which is done in this PR.

superjj18 · 2024-10-15T17:31:34Z

Pretty sure irl flare guns are 12 guage so yes they can totally fire lethal rounds.

I'd rather the lethal rounds work while also breaking the flare gun(and maybe causing some minor burn damage to the shooter). If you're going for realism that's probably better than arbitrarily limiting the type of round for no reason. If they want a quick burst of damage, they get one shot and a broken flaregun

Whitelists are lame and aren't communicated to the player

(Also I feel the manual reloading makes it more annoying to use, but at the same time I get why so that's easier to accept)

BramvanZijp · 2024-10-15T17:33:26Z

Pretty sure irl flare guns are 12 guage so yes they can totally fire lethal rounds.

I'd rather the lethal rounds work while also blowing up the flare gun, as if you're going for realism that's probably better than arbitrarily limiting the type of round for no reason.

Whitelists are lame and aren't communicated to the player

Ill find a way to have them blow up instead, should it just be the clown/monkey blow-up or an actual explosion?

Also, this is literally added to the item description but fair ig

KaiserMaus · 2024-10-15T17:35:36Z

What about makeshift shotgun shell? Flare can fire this munitions?

BramvanZijp · 2024-10-15T17:36:08Z

What about makeshift shotgun shell? Flare can fire this munitions?

That should probably be defined as a light shell yea

superjj18 · 2024-10-15T17:41:52Z

Pretty sure irl flare guns are 12 guage so yes they can totally fire lethal rounds.

I'd rather the lethal rounds work while also blowing up the flare gun, as if you're going for realism that's probably better than arbitrarily limiting the type of round for no reason.

Whitelists are lame and aren't communicated to the player

Ill find a way to have them blow up instead, should it just be the clown/monkey blow-up or an actual explosion?

Also, this is literally added to the item description but fair ig

I think it would slightly burn their hand. Wouldn't severely wound them or even knock them over, but the flare gun definitely wouldn't be able to fire again.(the handle and the barrel would likely break apart)

You could probably just separate the handle and barrel into two sprites, have the flaregun turn into a handle and spawn the barrel item on the ground. Something like that

BramvanZijp · 2024-10-16T07:47:29Z

Its going to be a pain to properly sort the flaregun blowing up with lethal shells in this PR, and it also feels a bit too far out of its scope. So It has been removed, if somebody else wants to re-add #22349 properly, please do so (And please make sure the sec shell gun is not effected.)

BramvanZijp · 2024-10-16T07:50:53Z

(To clarify, this means that for now, flare guns can still fire lethal shells, which I originally removed in this PR.)

Resources/Prototypes/Entities/Objects/Weapons/Guns/flare_gun.yml

chromiumboy · 2024-10-26T04:20:11Z

Resources/Prototypes/Entities/Objects/Weapons/Guns/flare_gun.yml

+  name: security shell gun
+  parent: [BaseItem, BaseSecurityContraband]
+  id: WeaponFlareGunSecurity
+  description: A modified flare gun designed to be used by security to launch non-lethal shotgun shells such as beanbags or tranquilizers. Can still fire lethal shells if neccesary.


If it's suppose to be a non-lethal device, I'm not sure if it firing lethal shells is a good idea. What purpose is this meant to serve?

All new weapons need approval by either sloth or DrSmugleaf (#8524)

Well... it's realistic as many irl flare guns are 12 gauge, and it's kind of a cool cheap improvised weapon.

Quoted from #design-discussion.

Regular passengers will only have access to the regular flare gun (made out of plastic). You can fire shells in it just fine, but if you try to fire any shell other than a flare shell, the flaregun explodes and turns into a broken one, and we can maybe roll a 50% for the gun blowing up in their hand (clumsy system) or it “””working””” and shooting the shot, but one time.

Security will get a metal flaregun that just works with all shells. This is how they work in real life.

Furthermore, the purpose of being able to fire lethal shells is both realism and for in an emergency self defense situation. I would assume giving out lethal sec shell guns is still considered a lethal weapon and thus code red only.
As for the weapon approval, a maintainer said it should be fine unless somebody complains, so let me know if I need to still get review keeping in mind this is just a reskin of an already existing weapon while that weapon is being changed to no longer be lethal.

Resources/Textures/Objects/Weapons/Guns/Shotguns/flaregun_security.rsi/meta.json

Everturning · 2024-10-28T13:48:28Z

i dont understand why security needs a shell gun

BramvanZijp · 2024-10-28T13:50:01Z

i dont understand why security needs a shell gun

Its to give security more options with less lethal ammo like beanbags or tranquilizers. They are currently very rare to see since if you are allowed to carry a full blown shotgun you would just use lethals with it, so this serves as a way to make these ammo types available without the big red alert grade weapons.

BramvanZijp · 2024-10-28T13:51:00Z

(Also if somebody rebalances tasers as a t3 tech for security, a taser shell (like an XREP) would also be really cool to use with this.)

Everturning · 2024-10-28T15:54:06Z

i dont understand why security needs a shell gun

Its to give security more options with less lethal ammo like beanbags or tranquilizers. They are currently very rare to see since if you are allowed to carry a full blown shotgun you would just use lethals with it, so this serves as a way to make these ammo types available without the big red alert grade weapons.

well I dont see why. this isn't really a niche that needs to be filled. disablers already do the job of taking down enemies at a distance far better than a beanbag shotgun ever could, and tranqs are used mostly in tandem with lethals. security really does not need a miniature shotgun in their pocket even if it's able to be used on green or whatever. besides, you said in the PR description that it can shoot lethal shells, so that goes against that whole point.

BramvanZijp · 2024-10-28T17:41:09Z

i dont understand why security needs a shell gun

Its to give security more options with less lethal ammo like beanbags or tranquilizers. They are currently very rare to see since if you are allowed to carry a full blown shotgun you would just use lethals with it, so this serves as a way to make these ammo types available without the big red alert grade weapons.

well I dont see why. this isn't really a niche that needs to be filled. disablers already do the job of taking down enemies at a distance far better than a beanbag shotgun ever could, and tranqs are used mostly in tandem with lethals. security really does not need a miniature shotgun in their pocket even if it's able to be used on green or whatever. besides, you said in the PR description that it can shoot lethal shells, so that goes against that whole point.

Its able to shoot lethals in an emergency. And a niche that doesnt NEED to be filled doesnt mean it wouldnt be a nice addition to spice up gameplay. Disabler SMG wasnt a niche that NEEDED to be filled for the same reason, but its still a nice addition.

Everturning · 2024-10-28T18:14:47Z

i dont understand why security needs a shell gun

Its to give security more options with less lethal ammo like beanbags or tranquilizers. They are currently very rare to see since if you are allowed to carry a full blown shotgun you would just use lethals with it, so this serves as a way to make these ammo types available without the big red alert grade weapons.

well I dont see why. this isn't really a niche that needs to be filled. disablers already do the job of taking down enemies at a distance far better than a beanbag shotgun ever could, and tranqs are used mostly in tandem with lethals. security really does not need a miniature shotgun in their pocket even if it's able to be used on green or whatever. besides, you said in the PR description that it can shoot lethal shells, so that goes against that whole point.

Its able to shoot lethals in an emergency. And a niche that doesnt NEED to be filled doesnt mean it wouldnt be a nice addition to spice up gameplay. Disabler SMG wasnt a niche that NEEDED to be filled for the same reason, but its still a nice addition.

okay? define an emergency in in-game mechanics. how will the GUN decide what's an emergency or not?

chromiumboy

I've reviewed the PR and there's a few things that need to be adjusted. But overall I like the changes to the flare gun, they are quite fitting thematically

I've left some code comments on the shell gun, however, I honestly don't really see how it fits into security. Security has access to disablers, which are just overall better, and has access to shotguns that can fire all the shells that the shell gun does. It has very low DPS, so security are going use their pistols if lethal action is necessary. And sure, you can print shell guns for the crew in an emergency, but if the situtauion is that dire that the crew needs to be armed, security can hand out better weapons, print lasers with just a little research, or just have cargo order more weapons

Resources/Prototypes/Entities/Objects/Weapons/Guns/flare_gun.yml

Resources/Textures/Objects/Weapons/Guns/Shotguns/flaregun.rsi/meta.json

…on-14 into SecShellGun

chromiumboy

While I still have my reservations about the role of the shell gun, I don't see the harm in it, and Sloth has OK'ed it. So if you can find another maintainer to approve it, it looks good to go

SlamBamActionman

This PR seems to have an issue that I haven't seen brought up; since this copies gun code, it has a "Rack" action that doesn't make sense. Not only is it not necessary to use the gun ingame, but it also takes up the Use action verb, making it impossible to close/open the flaregun using the keyboard. So that would need to be removed, and is the primary blocker for this PR right now.

As-is, this gun completely nullifies the Improvised Shotgun. I've seen that the intention is to make it explode on other shells, so that should really be prioritized.

Added the security shell gun to the security techfab, a modified flare gun designed to let security fire nonlethal .50 shells, though it can also fire lethal shells in a pinch.

I would personally not use this primarily for non-lethals. It's a decent one-shot burst that you can pull out from your pocket in an instant, very similar to the sawn-off, and as previously mentioned if Security wants to disable someone they have other options. I do think it makes for a good addition to the gun arsenal though. I would just state that it's rated for all shotgun shells in its description/in the changelog, instead to specify it's made for non-lethals.

BramvanZijp · 2024-11-03T17:38:41Z

This PR seems to have an issue that I haven't seen brought up; since this copies gun code, it has a "Rack" action that doesn't make sense. Not only is it not necessary to use the gun ingame, but it also takes up the Use action verb, making it impossible to close/open the flaregun using the keyboard. So that would need to be removed, and is the primary blocker for this PR right now.

As-is, this gun completely nullifies the Improvised Shotgun. I've seen that the intention is to make it explode on other shells, so that should really be prioritized.

Added the security shell gun to the security techfab, a modified flare gun designed to let security fire nonlethal .50 shells, though it can also fire lethal shells in a pinch.

I would personally not use this primarily for non-lethals. It's a decent one-shot burst that you can pull out from your pocket in an instant, very similar to the sawn-off, and as previously mentioned if Security wants to disable someone they have other options. I do think it makes for a good addition to the gun arsenal though. I would just state that it's rated for all shotgun shells in its description/in the changelog, instead to specify it's made for non-lethals.

Ill remove the rack verb from it.
The flare gun explode on other shell will be implemented once #31147 is merged (please merge this), keep in mind that right now the vanilla flaregun cannot fire lethals at all when this PR is merged.
Ill update the description & changelog with this in mind.

…on-14 into SecShellGun

…p the gun

K-Dynamic · 2024-11-06T21:30:44Z

If there's a break action mechanic, it should apply to the double barrel shotgun too

BramvanZijp · 2024-11-06T21:37:39Z

If there's a break action mechanic, it should apply to the double barrel shotgun too

Much harder to do since it should hold 2 rounds, but should prolly be done yeah.

* Rework flaregun and add security shell gun * Make flare gun twice as likely to appear in emergency lockers * Security shell gun can now fire lethal shells like the flare gun used to be able to. * Rebalance the sec shell gun material cost to primarily be steel instead of plastic * Define the ShellShotgunLight tag in tags.yml * Leave the no lethal shells for normal flareguns to a different PR. * Move a comment to re-run checks. * Bye bye lethal shells from plastic guns. * Fix weird whitespace issue. * Make the sec shell gun inherit the normal flare gun. * Remove the rack verb and update the sec shell gun description * Remove the ability to fire lethals from flare guns, pending blowing up the gun --------- Co-authored-by: SlamBamActionman <[email protected]>

BramvanZijp added 3 commits October 15, 2024 16:30

Rework flaregun and add security shell gun

a0c98d5

Make flare gun twice as likely to appear in emergency lockers

516fd35

Security shell gun can now fire lethal shells like the flare gun used…

80eac99

… to be able to.

github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Oct 15, 2024

BramvanZijp added 2 commits October 15, 2024 17:45

Rebalance the sec shell gun material cost to primarily be steel inste…

42dec1e

…ad of plastic

Define the ShellShotgunLight tag in tags.yml

4446e21

Leave the no lethal shells for normal flareguns to a different PR.

859876b

Move a comment to re-run checks.

ef01c4d

chromiumboy requested changes Oct 26, 2024

View reviewed changes

chromiumboy added the S: Awaiting Changes Status: Changes are required before another review can happen label Oct 26, 2024

chromiumboy self-assigned this Oct 26, 2024

Bye bye lethal shells from plastic guns.

b1e9217

BramvanZijp requested a review from chromiumboy October 26, 2024 09:25

github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Oct 26, 2024

metalgearsloth reviewed Oct 28, 2024

View reviewed changes

Resources/Textures/Objects/Weapons/Guns/Shotguns/flaregun_security.rsi/meta.json Outdated Show resolved Hide resolved

Fix weird whitespace issue.

aba105d

chromiumboy requested changes Oct 29, 2024

View reviewed changes

Resources/Prototypes/Entities/Objects/Weapons/Guns/flare_gun.yml Outdated Show resolved Hide resolved

Resources/Prototypes/Entities/Objects/Weapons/Guns/flare_gun.yml Show resolved Hide resolved

Resources/Textures/Objects/Weapons/Guns/Shotguns/flaregun.rsi/meta.json Show resolved Hide resolved

BramvanZijp added 2 commits October 29, 2024 09:59

Merge branch 'master' of https://github.com/space-wizards/space-stati…

f2349e6

…on-14 into SecShellGun

Make the sec shell gun inherit the normal flare gun.

e41a879

BramvanZijp requested a review from chromiumboy October 29, 2024 09:25

chromiumboy approved these changes Oct 31, 2024

View reviewed changes

chromiumboy added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Oct 31, 2024

SlamBamActionman requested changes Nov 2, 2024

View reviewed changes

BramvanZijp added 2 commits November 3, 2024 18:47

Remove the rack verb and update the sec shell gun description

462c1f4

Merge branch 'master' of https://github.com/space-wizards/space-stati…

d6eb79a

…on-14 into SecShellGun

BramvanZijp requested a review from SlamBamActionman November 3, 2024 18:29

github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Nov 3, 2024

Remove the ability to fire lethals from flare guns, pending blowing u…

e6c5405

…p the gun

SlamBamActionman approved these changes Nov 6, 2024

View reviewed changes

SlamBamActionman merged commit d588409 into space-wizards:master Nov 6, 2024
13 checks passed

Errant-4 mentioned this pull request Nov 10, 2024

HOTFIX: Fix Security Shell Gun being uncraftable. #33247

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rework the Flare Gun & add a Security Shell Gun. #32829

Rework the Flare Gun & add a Security Shell Gun. #32829

BramvanZijp commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

BramvanZijp commented Oct 15, 2024

superjj18 commented Oct 15, 2024 •

edited

Loading

BramvanZijp commented Oct 15, 2024 •

edited

Loading

KaiserMaus commented Oct 15, 2024

BramvanZijp commented Oct 15, 2024

superjj18 commented Oct 15, 2024 •

edited

Loading

BramvanZijp commented Oct 16, 2024

BramvanZijp commented Oct 16, 2024 •

edited

Loading

chromiumboy Oct 26, 2024

superjj18 Oct 26, 2024

BramvanZijp Oct 26, 2024 •

edited

Loading

Everturning commented Oct 28, 2024

BramvanZijp commented Oct 28, 2024

BramvanZijp commented Oct 28, 2024

Everturning commented Oct 28, 2024

BramvanZijp commented Oct 28, 2024

Everturning commented Oct 28, 2024

chromiumboy left a comment •

edited

Loading

chromiumboy left a comment •

edited

Loading

SlamBamActionman left a comment •

edited

Loading

BramvanZijp commented Nov 3, 2024

K-Dynamic commented Nov 6, 2024

BramvanZijp commented Nov 6, 2024

Rework the Flare Gun & add a Security Shell Gun. #32829

Rework the Flare Gun & add a Security Shell Gun. #32829

Conversation

BramvanZijp commented Oct 15, 2024 • edited Loading

About the PR

Why / Balance

Technical details

Media

Requirements

github-actions bot commented Oct 15, 2024 • edited Loading

BramvanZijp commented Oct 15, 2024

superjj18 commented Oct 15, 2024 • edited Loading

BramvanZijp commented Oct 15, 2024 • edited Loading

KaiserMaus commented Oct 15, 2024

BramvanZijp commented Oct 15, 2024

superjj18 commented Oct 15, 2024 • edited Loading

BramvanZijp commented Oct 16, 2024

BramvanZijp commented Oct 16, 2024 • edited Loading

chromiumboy Oct 26, 2024

Choose a reason for hiding this comment

superjj18 Oct 26, 2024

Choose a reason for hiding this comment

BramvanZijp Oct 26, 2024 • edited Loading

Choose a reason for hiding this comment

Everturning commented Oct 28, 2024

BramvanZijp commented Oct 28, 2024

BramvanZijp commented Oct 28, 2024

Everturning commented Oct 28, 2024

BramvanZijp commented Oct 28, 2024

Everturning commented Oct 28, 2024

chromiumboy left a comment • edited Loading

Choose a reason for hiding this comment

chromiumboy left a comment • edited Loading

Choose a reason for hiding this comment

SlamBamActionman left a comment • edited Loading

Choose a reason for hiding this comment

BramvanZijp commented Nov 3, 2024

K-Dynamic commented Nov 6, 2024

BramvanZijp commented Nov 6, 2024

BramvanZijp commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

superjj18 commented Oct 15, 2024 •

edited

Loading

BramvanZijp commented Oct 15, 2024 •

edited

Loading

superjj18 commented Oct 15, 2024 •

edited

Loading

BramvanZijp commented Oct 16, 2024 •

edited

Loading

BramvanZijp Oct 26, 2024 •

edited

Loading

chromiumboy left a comment •

edited

Loading

chromiumboy left a comment •

edited

Loading

SlamBamActionman left a comment •

edited

Loading