New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix opcode 8 handler: onRequestGuildMembers #1233

Merged

MaddyUnderStars merged 1 commit into spacebarchat:master from dank074:patch/fixOp8

Nov 14, 2024

+14 −12

Contributor

dank074 commented Nov 14, 2024

Addresses the following:

Query should not be case sensitive
When the query returns no member results, we should still return a guild member chunk with empty array of member results
There was a bug in the toPublicMember method that never set the user property of the Member entity object

Closes #1230


          fix op 8

bcbd823

dank074 changed the title ~~fix op 8 https://github.com/spacebarchat/server/issues/1230~~ fix op 8 #1230

dank074 changed the title ~~fix op 8 #1230~~ fix opcode 8 handler: onRequestGuildMembers

Member

MaddyUnderStars commented Nov 14, 2024

Great work, thanks a lot

MaddyUnderStars merged commit 762287e into spacebarchat:master

2 of 3 checks passed

dank074 deleted the patch/fixOp8 branch

November 14, 2024 21:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet