Show projected balance when there is pending transactions #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview the changes at : https://f124c9d3.smapp-lite-prod.pages.dev |
There was a problem hiding this comment.
I had some issues updating/reflecting the state - both to start showing this cool pending state and then ending it and showing tx as applied and balance confirmed. I recorded it, but didn’t process the rec so it's a bit long and boring.
Screen.Recording.2024-12-16.at.21.56.30.mov
| pendingBalance | ||
| ? `Available balance: ${balance.projected} Smidge\n` | ||
| : '' | ||
| }Actual balance: ${balance.current} Smidge`} |
There was a problem hiding this comment.
I don't know, maybe it's only me, but it's a bit misleading. Actual balance makes me think that I actually have this amount while I might no longer have it.
How about naming it pending or locked balance?
|
You can preview the changes at : https://f38ac0df.smapp-lite-prod.pages.dev |
monikasmolarek
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue.
Screen.Recording.2024-12-16.at.13.27.44.mov