Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Turn all unhandle warnings into errors in pytest #527

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Nov 14, 2024

Unleash the kraken!

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.42%. Comparing base (9cd8552) to head (1d38d05).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files          22       22           
  Lines        3874     3874           
=======================================
  Hits         3387     3387           
  Misses        487      487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pllim pllim marked this pull request as ready for review November 14, 2024 16:56
@pllim pllim requested a review from a team as a code owner November 14, 2024 16:56
@pllim
Copy link
Contributor Author

pllim commented Nov 14, 2024

Hmm 102 failed, 2623 passed, 721 skipped, 3 xfailed, 24 error in test_downstream but it is already red on master, so 🤷‍♀️

@pllim
Copy link
Contributor Author

pllim commented Nov 14, 2024

Some does look like warning from #522 came back to haunt you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant