update rotation_angle when _add_orientation is called

[gibsongreen]

Description

This pull request is to address updating the orientation plugin's rotation_angle when _add_orientation() is called via API.

Screen.Recording.2024-04-30.at.10.39.27.PM.mov

Screen.Recording.2024-04-30.at.10.38.06.PM.mov

Fixes #

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (95cf7f2) to head (1653e16).
Report is 301 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2838      +/-   ##
==========================================
+ Coverage   88.94%   88.96%   +0.01%     
==========================================
  Files         111      111              
  Lines       17101    17104       +3     
==========================================
+ Hits        15211    15217       +6     
+ Misses       1890     1887       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kecnry]

The rotation_angle traitlet isn't necessarily the currently set rotation, but rather the rotation that will be used if creating a new entry from the UI, right? (Side note: maybe we need a separate ticket to clarify this in the API docs?). I'm not sure I'd expect a kwarg to add_orientation from the API to change that value then (and if it does, we probably should do the same for east_left and label?).

Can you please remind me what buggy behavior this is aiming to fix? I am wondering if maybe the fix needs to be in footprints instead? EDIT: ah, it was with the automatic labeling not respecting the passed angle.

Maybe we can just refactor the labeling logic to act on the overrides instead of the traitlets? Although the API docs do say: "If None, the value will follow self.new_layer_label." which is exactly what happens before this PR 🤔