Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual Observatory plugin for Jdaviz #2872

Open
wants to merge 64 commits into
base: main
Choose a base branch
from
Open

Virtual Observatory plugin for Jdaviz #2872

wants to merge 64 commits into from

Commits on Jul 24, 2024

  1. Migrate VO plugin to Jdaviz

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a8a458e View commit details
    Browse the repository at this point in the history

  2. Print resource url in empty error

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b4c3530 View commit details
    Browse the repository at this point in the history

  3. Clarify degree unit on coord tooltip

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3b6ffa6 View commit details
    Browse the repository at this point in the history

  4. Catch connection error

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    0d688d9 View commit details
    Browse the repository at this point in the history

  5. Allow URL only override

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    945677c View commit details
    Browse the repository at this point in the history

  6. Automatically fallback table to URL-only if unable to get metadata co… 

    …lumns
    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    83fa048 View commit details
    Browse the repository at this point in the history

  7. Coordinate frame option

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    abb24ec View commit details
    Browse the repository at this point in the history

  8. Autocenter coords on viewer if data present

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    bb41ee5 View commit details
    Browse the repository at this point in the history

  9. Filter resource querying on coverage at source, adjust userflow to se… 

    …lect source before resource, add manual coordinate toggle to viewer dropdown
    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7fffc8f View commit details
    Browse the repository at this point in the history

  10. Coverage filtering toggle

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1c67aca View commit details
    Browse the repository at this point in the history

  11. Migrate resource_selected to v-model

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    bf4a94f View commit details
    Browse the repository at this point in the history

  12. Mark Source and Resource as required fields

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6a555f9 View commit details
    Browse the repository at this point in the history

  13. Remove redundant manual traitlet sync

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9348eef View commit details
    Browse the repository at this point in the history

  14. Set throwaway event args to optional

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d580c66 View commit details
    Browse the repository at this point in the history

  15. Drop vestigial argument signatures

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4e18af2 View commit details
    Browse the repository at this point in the history

  16. Set query registry to observe waveband_selected to avoid multiple reg… 

    …istry calls while typing the source name
    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    76581ca View commit details
    Browse the repository at this point in the history

  17. Add TODO comment

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    81e6cb1 View commit details
    Browse the repository at this point in the history

  18. Black Formatting

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    ca41b24 View commit details
    Browse the repository at this point in the history

  19. First draft documentation

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9d007b8 View commit details
    Browse the repository at this point in the history

  20. Fix doc references

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a3295ce View commit details
    Browse the repository at this point in the history

  21. Fix IVOA hyperlink

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    09a21bb View commit details
    Browse the repository at this point in the history

  22. Docs: Add mention to source name string input

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d22ddd7 View commit details
    Browse the repository at this point in the history

  23. Local autocenter test

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c0ecc2a View commit details
    Browse the repository at this point in the history

  24. Coverage toggle test

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2ca1cbf View commit details
    Browse the repository at this point in the history

  25. Move table population to testable method for local test

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a357e83 View commit details
    Browse the repository at this point in the history

  26. Test Formatting

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5ddd663 View commit details
    Browse the repository at this point in the history

  27. Add custom table header test

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    96b93c1 View commit details
    Browse the repository at this point in the history

  28. Switch to direct URL loading

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    e023d91 View commit details
    Browse the repository at this point in the history

  29. Add M51 load data test

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    ab8ae95 View commit details
    Browse the repository at this point in the history

  30. Add SIA2 warning

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a5e9970 View commit details
    Browse the repository at this point in the history

  31. Don't use cache to avoid loadtime warning

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    bbce480 View commit details
    Browse the repository at this point in the history

  32. Filter known data product warnings in load_data test

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c4146dc View commit details
    Browse the repository at this point in the history

  33. Document unit tests

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c19d01f View commit details
    Browse the repository at this point in the history

  34. Codestyle

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c884c69 View commit details
    Browse the repository at this point in the history

  35. Changelog

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4f3a967 View commit details
    Browse the repository at this point in the history

  36. Properly compare autocenter coord values as floats

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a18101c View commit details
    Browse the repository at this point in the history

  37. URL fallback needs to reset current entry to URL only if previous att… 

    …r have already been stored
    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    8ecce9e View commit details
    Browse the repository at this point in the history

  38. Table header URL fallback test

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f9cf202 View commit details
    Browse the repository at this point in the history

  39. Fix CSS height arg

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3ac2a7c View commit details
    Browse the repository at this point in the history

  40. Drop vestigial ICRS frame requirement in tooltip

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    08f3696 View commit details
    Browse the repository at this point in the history

  41. Codestyle

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    5b6eeef View commit details
    Browse the repository at this point in the history

  42. Syntax fix

    @duytnguyendtn
    duytnguyendtn committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c41b72f View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Only lookup source coordinate in registry query IF coverage filtering… 

    … is enabled
    @duytnguyendtn
    duytnguyendtn committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    606d6a8 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Define center coordinates as attr for reference in other tests

    @duytnguyendtn
    duytnguyendtn committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    9b6a60b View commit details
    Browse the repository at this point in the history

  2. Only block registry querying if no source and filtering enabled. Allo… 

    …w no source querying when filtering disabled
    @duytnguyendtn
    duytnguyendtn committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    aebd564 View commit details
    Browse the repository at this point in the history

  3. Clear source field if autocoord viewer has no data

    @duytnguyendtn
    duytnguyendtn committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    437d395 View commit details
    Browse the repository at this point in the history

  4. Test comments

    @duytnguyendtn
    duytnguyendtn committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    00b0da1 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Test for source error snackbar messages

    @duytnguyendtn
    duytnguyendtn committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    dc5a4de View commit details
    Browse the repository at this point in the history

  2. Disable registry coverage filtering by default (per Cami request)

    @duytnguyendtn
    duytnguyendtn committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b9aa8e1 View commit details
    Browse the repository at this point in the history

  3. Test load data error messages

    @duytnguyendtn
    duytnguyendtn committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    c250c1f View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Warn users about potentially misaligned data if WCS linking isn't ena… 

    …bled
    @duytnguyendtn
    duytnguyendtn committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    10d712d View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Load data errors do not prevent subsequent data products from loading 

    TEST: Combine load_data error test to main load_data test
    @duytnguyendtn
    duytnguyendtn committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    d4f152a View commit details
    Browse the repository at this point in the history

  2. Test organization, codestyle

    @duytnguyendtn
    duytnguyendtn committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    e2e463d View commit details
    Browse the repository at this point in the history

  3. Test that loading spinners turn off when operations are complete

    @duytnguyendtn
    duytnguyendtn committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    49eefb7 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Effectively disable timeout

    @duytnguyendtn
    duytnguyendtn committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5a61cc9 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Recalculate autocoord when linktype changes

    @duytnguyendtn
    duytnguyendtn committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c0e9086 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Allow float degrees

    @duytnguyendtn
    duytnguyendtn committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ea2562e View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Add support for radius units

    @duytnguyendtn
    duytnguyendtn committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    783262a View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Use UnitSelectPluginComponent for radius unit

    @duytnguyendtn
    duytnguyendtn committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5742480 View commit details
    Browse the repository at this point in the history

  2. Add viewer force recenter button

    @duytnguyendtn
    duytnguyendtn committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    03a00e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Allow plugin to follow viewer coords thru panning

    @duytnguyendtn
    duytnguyendtn committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    300f194 View commit details
    Browse the repository at this point in the history

  2. Don't bother subscribing if we're on Manual

    @duytnguyendtn
    duytnguyendtn committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8898c55 View commit details
    Browse the repository at this point in the history

  3. Update test method call after renaming

    @duytnguyendtn
    duytnguyendtn committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0ff66b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. UI: Change autocenterbtn icon to indicate when coords are centered or… 

    … not
    @duytnguyendtn
    duytnguyendtn committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    fd89b64 View commit details
    Browse the repository at this point in the history