Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert flux cubes to per-square-pixel surface brightness cubes #3156

Merged
merged 77 commits into from
Sep 20, 2024
Merged

convert flux cubes to per-square-pixel surface brightness cubes #3156

merged 77 commits into from
Sep 20, 2024

Commits on Sep 6, 2024

  1. checkpoint

    @cshanahan1
    cshanahan1 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ca3e40e View commit details
    Browse the repository at this point in the history

  2. clean up

    @cshanahan1
    cshanahan1 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    cd688bb View commit details
    Browse the repository at this point in the history

  3. code style

    @cshanahan1
    cshanahan1 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    8ead071 View commit details
    Browse the repository at this point in the history

  4. remove debugging

    @cshanahan1
    cshanahan1 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a6004ee View commit details
    Browse the repository at this point in the history

  5. fixed equivs, more tests passing?

    @cshanahan1
    cshanahan1 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3ea11dc View commit details
    Browse the repository at this point in the history

  6. fix untranslatable units for per pixels

    @cshanahan1
    cshanahan1 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7588350 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. fixed mm

    @cshanahan1
    cshanahan1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    61b6180 View commit details
    Browse the repository at this point in the history

  2. .

    @cshanahan1
    cshanahan1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5a7cd22 View commit details
    Browse the repository at this point in the history

  3. fix mouseover for sr

    @cshanahan1
    cshanahan1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e4c37e3 View commit details
    Browse the repository at this point in the history

  4. fixed batch ap phot

    @cshanahan1
    cshanahan1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e18f011 View commit details
    Browse the repository at this point in the history

  5. fix lingering issues

    @cshanahan1
    cshanahan1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6fb04c8 View commit details
    Browse the repository at this point in the history

  6. getting up to date

    @cshanahan1
    cshanahan1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6da11d8 View commit details
    Browse the repository at this point in the history

  7. change log

    @cshanahan1
    cshanahan1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6a455fa View commit details
    Browse the repository at this point in the history

  8. code style

    @cshanahan1
    cshanahan1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    7ba9260 View commit details
    Browse the repository at this point in the history

  9. doc

    @cshanahan1
    cshanahan1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    39f6fbd View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. checkpoint

    @cshanahan1
    cshanahan1 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    fde48d3 View commit details
    Browse the repository at this point in the history

  2. getting up to date

    @cshanahan1
    cshanahan1 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    bc25704 View commit details
    Browse the repository at this point in the history

  3. removing example from docstring because it keeps causing issues

    @cshanahan1
    cshanahan1 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    061760d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. line analysis fixes

    @cshanahan1
    cshanahan1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    97e6c90 View commit details
    Browse the repository at this point in the history

  2. code style

    @cshanahan1
    cshanahan1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b539bd9 View commit details
    Browse the repository at this point in the history

  3. fix docs

    @cshanahan1
    cshanahan1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a49578e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. test

    @cshanahan1
    cshanahan1 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9139e38 View commit details
    Browse the repository at this point in the history

  2. .

    @cshanahan1
    cshanahan1 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b715139 View commit details
    Browse the repository at this point in the history

  3. reverting wrong change selected in rebase

    @cshanahan1
    cshanahan1 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ad182d9 View commit details
    Browse the repository at this point in the history

  4. more missing code from main

    @cshanahan1
    cshanahan1 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2ad22ff View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. review comment

    @cshanahan1
    cshanahan1 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7f6eb00 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into non-sr-sb

    @cshanahan1
    cshanahan1 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    171690c View commit details
    Browse the repository at this point in the history

  3. small review changes

    @cshanahan1
    cshanahan1 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b2a72b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. code style

    @cshanahan1
    cshanahan1 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f90655e View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. fix formatting of unit after appending angle

    @cshanahan1
    cshanahan1 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e824d32 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge branch 'fix_unit_ordering' into non-sr-sb

    @cshanahan1
    cshanahan1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b957999 View commit details
    Browse the repository at this point in the history

  2. review comments, skip test

    @cshanahan1
    cshanahan1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    28bdf76 View commit details
    Browse the repository at this point in the history

  3. review comments, counts support

    @cshanahan1
    cshanahan1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    29ddeed View commit details
    Browse the repository at this point in the history

  4. code style

    @cshanahan1
    cshanahan1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    978ed24 View commit details
    Browse the repository at this point in the history

  5. added test, cleanup

    @cshanahan1
    cshanahan1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    832ee45 View commit details
    Browse the repository at this point in the history

  6. skip test in viewers

    @cshanahan1
    cshanahan1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d7aea3c View commit details
    Browse the repository at this point in the history

  7. skip test in parsers

    @cshanahan1
    cshanahan1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    aa0d384 View commit details
    Browse the repository at this point in the history

  8. remove var def to avoid line overflow

    @cshanahan1
    cshanahan1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7cad3f2 View commit details
    Browse the repository at this point in the history

  9. remove new traitlet in ap_phot

    @cshanahan1
    cshanahan1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    bc75ff7 View commit details
    Browse the repository at this point in the history

  10. code style 

    ;
    @cshanahan1
    cshanahan1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    0a38dbc View commit details
    Browse the repository at this point in the history

  11. added back in old test, updated docstrings

    @cshanahan1
    cshanahan1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e9dedb3 View commit details
    Browse the repository at this point in the history

  12. review comments

    @cshanahan1
    cshanahan1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3e6701d View commit details
    Browse the repository at this point in the history

  13. pllim review from 3192

    @cshanahan1
    cshanahan1 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    709b440 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. update for imviz aperphot

    @cshanahan1
    cshanahan1 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c5894d1 View commit details
    Browse the repository at this point in the history

  2. final review comments from kyle

    @cshanahan1
    cshanahan1 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6319b05 View commit details
    Browse the repository at this point in the history

  3. Fix NaN handling in cube fitting and initial fixes for unit conversio… 

    …n/model fitting interaction
    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    645c254 View commit details
    Browse the repository at this point in the history

  4. Remove debugging prints, add comment for context

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    79081d1 View commit details
    Browse the repository at this point in the history

  5. Codestyle, changelog

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7520892 View commit details
    Browse the repository at this point in the history

  6. Reestimate parameters when cube fitting is toggled

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7d0823b View commit details
    Browse the repository at this point in the history

  7. Only reestimate if spectral y type isn't SB

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ee5a108 View commit details
    Browse the repository at this point in the history

  8. Codestyle

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c94ef87 View commit details
    Browse the repository at this point in the history

  9. Changelog

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c24b6c2 View commit details
    Browse the repository at this point in the history

  10. Fix initializing linear component for cube fit

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    dabcc84 View commit details
    Browse the repository at this point in the history

  11. Handle linear component estimation for cube case

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a7046c4 View commit details
    Browse the repository at this point in the history

  12. Only reshape here in 3D case

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a42173c View commit details
    Browse the repository at this point in the history

  13. Skip tests that need spacetelescope#3156

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f405609 View commit details
    Browse the repository at this point in the history

  14. Respect selected display units when initializing model components

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d8972b3 View commit details
    Browse the repository at this point in the history

  15. Use app._get_display_unit instead of relying on Unit Conversion

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fcba42b View commit details
    Browse the repository at this point in the history

  16. Add equivalency here

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9abc3bf View commit details
    Browse the repository at this point in the history

  17. Only reestimate here if sb unit != spectral_y unit

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4a1a10f View commit details
    Browse the repository at this point in the history

  18. Don't automatically reestimate when toggling cube fit, make the user … 

    …do it
    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5a0b525 View commit details
    Browse the repository at this point in the history

  19. Remove print

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a50c940 View commit details
    Browse the repository at this point in the history

  20. Check for warning in test after cube toggle 

    Fix test

Codestyle
    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d3dbcd9 View commit details
    Browse the repository at this point in the history

  21. Add test for cube fitting after flux unit change

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    529bb74 View commit details
    Browse the repository at this point in the history

  22. Add a to-do about a test for unit conversion with equivalency

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    35d2d96 View commit details
    Browse the repository at this point in the history

  23. merge cube fit branch

    @cshanahan1
    cshanahan1 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6cda3c3 View commit details
    Browse the repository at this point in the history

  24. Fix failing test

    @rosteen
    rosteen committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f46e9d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Merge remote-tracking branch 'Ricky/cube-fit-units-fix' into non-sr-sb

    @cshanahan1
    cshanahan1 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    19dcdf6 View commit details
    Browse the repository at this point in the history

  2. review comments

    @cshanahan1
    cshanahan1 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    de68a5e View commit details
    Browse the repository at this point in the history

  3. .

    @cshanahan1
    cshanahan1 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a476aa8 View commit details
    Browse the repository at this point in the history

  4. model fitting tests

    @cshanahan1
    cshanahan1 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2c30af6 View commit details
    Browse the repository at this point in the history

  5. Back to parallel processing post-debugging

    @rosteen
    rosteen committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b33dcc0 View commit details
    Browse the repository at this point in the history

  6. review comments

    @cshanahan1
    cshanahan1 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    28956fa View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'Ricky/cube-fit-units-fix' into non-sr-sb

    @cshanahan1
    cshanahan1 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    543bea9 View commit details
    Browse the repository at this point in the history

  8. code style

    @cshanahan1
    cshanahan1 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    59ed5a8 View commit details
    Browse the repository at this point in the history

  9. .

    @cshanahan1
    cshanahan1 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7d5896c View commit details
    Browse the repository at this point in the history

  10. move import

    @cshanahan1
    cshanahan1 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5d9078e View commit details
    Browse the repository at this point in the history