Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix typo on internal method #3172

Merged
merged 1 commit into from
Aug 28, 2024
Merged

BUG: Fix typo on internal method #3172

merged 1 commit into from
Aug 28, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Aug 27, 2024

Description

Small typo but should still fix it.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added bug Something isn't working trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Aug 27, 2024
@pllim pllim added this to the 4.0 milestone Aug 27, 2024
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Aug 27, 2024
@rosteen
Copy link
Collaborator

rosteen commented Aug 27, 2024

I swear I saw this fixed in another PR within the last couple of days, might be in review.

@rosteen
Copy link
Collaborator

rosteen commented Aug 27, 2024

Yeah, Kyle had also fixed this in #3157, which is waiting on another PR to get in first.

@pllim
Copy link
Contributor Author

pllim commented Aug 27, 2024

If you don't want a trivial independent fix for this typo, feel free to close. Otherwise we can merge so we do not have to wait for that other PR that is currently "stuck". Up to you.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (ca0b107) to head (bd6fc4f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3172   +/-   ##
=======================================
  Coverage   88.42%   88.42%           
=======================================
  Files         122      122           
  Lines       18267    18267           
=======================================
  Hits        16153    16153           
  Misses       2114     2114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't affect any functionality since both cases have the same typo, but doesn't hurt to get in sooner either.

@pllim pllim merged commit 69e31b7 into spacetelescope:main Aug 28, 2024
32 checks passed
@pllim pllim deleted the wut branch August 28, 2024 14:19
@pllim
Copy link
Contributor Author

pllim commented Aug 28, 2024

Ok then, I merged it. One less typo to worry about. Hopefully the rebase will be easy for you. Thanks for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cubeviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants