Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace usage of copy_arrays=True with memmap=False #8660

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Jul 18, 2024

follow-on to asdf-format/asdf#1797

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.36%. Comparing base (4c50426) to head (573667b).

Files with missing lines Patch % Lines
jwst/lib/set_telescope_pointing.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8660   +/-   ##
=======================================
  Coverage   60.36%   60.36%           
=======================================
  Files         372      372           
  Lines       38325    38326    +1     
=======================================
+ Hits        23136    23137    +1     
  Misses      15189    15189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett
Copy link
Collaborator Author

@zacharyburnett zacharyburnett marked this pull request as ready for review July 18, 2024 19:55
@zacharyburnett zacharyburnett requested a review from a team as a code owner July 18, 2024 19:55
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zacharyburnett zacharyburnett merged commit e34f4d8 into spacetelescope:master Aug 2, 2024
21 of 22 checks passed
@zacharyburnett zacharyburnett deleted the deprecate/copy_arrays branch August 2, 2024 20:05
@nden nden added this to the Build 11.1 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants