Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace usages of copy_arrays with memmap #1316

Merged
merged 3 commits into from
Jul 18, 2024
Merged

replace usages of copy_arrays with memmap #1316

merged 3 commits into from
Jul 18, 2024

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Jul 18, 2024 •
edited
Loading

follow-on to asdf-format/asdf#1797

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@zacharyburnett zacharyburnett self-assigned this Jul 18, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation linearity regression_testing labels Jul 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.28%. Comparing base (2b19fc4) to head (16a4187).
Report is 246 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1316   +/-   ##
=======================================
  Coverage   79.28%   79.28%           
=======================================
  Files         117      117           
  Lines        8065     8065           
=======================================
  Hits         6394     6394           
  Misses       1671     1671
Flag Coverage Δ *Carryforward flag
nightly 62.98% <ø> (ø) Carriedforward from 58e5fcb

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett
Copy link
Collaborator Author

regtest: https://github.com/spacetelescope/RegressionTests/actions/runs/9994064288

@braingram
Copy link
Collaborator

Would you bump the asdf version to at least 3.1.0:

romancal/pyproject.toml

Line 16 in 2b19fc4

"asdf >=2.15.0",

That should fix the oldestdeps.

@zacharyburnett zacharyburnett marked this pull request as ready for review July 18, 2024 16:03
@zacharyburnett zacharyburnett requested a review from a team as a code owner July 18, 2024 16:03
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jul 18, 2024
braingram
braingram approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zacharyburnett zacharyburnett enabled auto-merge (squash) July 18, 2024 16:05
@zacharyburnett zacharyburnett merged commit 7476678 into spacetelescope:main Jul 18, 2024
26 checks passed
zacharyburnett added a commit to zacharyburnett/romancal that referenced this pull request Jul 22, 2024
@zacharyburnett
replace usages of copy_arrays with memmap (spacetelescope#1316)
5f9d8d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braingram braingram braingram approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation linearity regression_testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharyburnett @braingram