Rename settings and the way settings are loaded #418
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the most part this is backwards compatible, though there are some edge-case bc breakages.
Base File.sublime-settings
toDocBlockr.sublime-settings
#313What does it change?
jsdocs_*
todocblockr.*
.User/Preferences.sublime-settings
instead ofUser/Base File.sublime-settings
.The trickiest part is making sure the refactor is backwards compatible. See here for relevant settings migration code.
Is this something that will be accepted to merge?
I'm happy to address any issues to get this change merged.