-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: openapi config override #1002
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
how does this work with subrouters? The user would already have all endpoints in the |
CodSpeed Performance ReportMerging #1002 will degrade performances by 11.29%Comparing Summary
Benchmarks breakdown
|
@VishnuSanal , yes. Subrouters should not have the ability to override openapi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some suggestions @VishnuSanal
robyn/__init__.py
Outdated
if openapi_file_path: | ||
openapi.set_json_spec(self.directory_path + "/" + openapi_file_path) | ||
elif os.path.isfile(self.directory_path + "/openapi.json"): | ||
openapi.set_json_spec(self.directory_path + "/openapi.json") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VishnuSanal , could you explain the logic here? What is this supposed to do?
It should just be a file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should invoke the override function if the path param is set or if the file i9s present in the pre-defnked path
Co-authored-by: Sanskar Jethi <[email protected]>
Description
This PR fixes #961
Summary
This PR does add openapi config override feat
PR Checklist
Please ensure that:
Pre-Commit Instructions: