feat(lib.rs): add mimalloc as the global allocator #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for robyn canceled.
|
CodSpeed Performance ReportMerging #578 will not alter performanceComparing Summary
|
sansyrox
force-pushed
the
main
branch
2 times, most recently
from
5588625
to
d04fb5e
Compare
|
This issue will be fixed when we retire python 3.7 |
|
Interesting @sansyrox ! I am learning more about allocators and I'd be interested to know what motivated you to choose mimalloc over default system allocator? I see there are some other allocators as well (for example: tcmalloc, etc.). Why do we choose mimalloc here specifically? Thanks! |
|
Hey @banipreetr 👋 Mimalloc offers a better performance in general cases. See here https://www.microsoft.com/en-us/research/uploads/prod/2019/06/mimalloc-tr-v1.pdf We will have to properly integrate it here and benchmark the benefits it brings for us 😄 |
sansyrox
force-pushed
the
feat/add-mi-malloc
branch
from
d602186
to
70e76e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new allocator, this will result in a performance boost