Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace body attribute in Response Object in the docs #586

Closed
wants to merge 3 commits into from

Conversation

carlosm27
Copy link
Contributor

Description
This PR replace the body attribute for description attribute in the section relate to the Response object in the documentation.

This PR fixes #

@netlify
Copy link

netlify bot commented Aug 19, 2023

👷 Deploy request for robyn pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9ac1b99

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 20, 2023

CodSpeed Performance Report

Merging #586 will not alter performance

Comparing carlosm27:docs-response-object (9ac1b99) with main (2ffd591)

Summary

✅ 100 untouched benchmarks

@IdoKendo
Copy link
Contributor

Hey @carlosm27 👋 I think you can update the docs in the same PR as updating the syntax (#580), there's no need for separating the code and docs in two PRs.

@carlosm27
Copy link
Contributor Author

carlosm27 commented Aug 22, 2023

Hey @sansyrox, sorry, my bad. Thank you for tell me. I will update the docs in the #580 PR.

@sansyrox
Copy link
Member

Thanks @carlosm27 for the tag. But I think you mean @IdoKendo 😉

@carlosm27
Copy link
Contributor Author

Yes, that was what I meant. I´m sorry to both of you for the misunderstanding.

@sansyrox
Copy link
Member

Hey @carlosm27 👋

I have moved your commit to your other PR 😄 We can safely close this.

@sansyrox sansyrox closed this Aug 26, 2023
@carlosm27 carlosm27 deleted the docs-response-object branch September 18, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants