chore: decrease .whl filesize #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for robyn pending review.Visit the deploys page to approve it
|
CodSpeed Performance ReportMerging #603 will not alter performanceComparing Summary
|
sansyrox
reviewed
Sep 13, 2023
Comment on lines
+42
to
+44
| codegen-units = 1 | ||
| lto = true | ||
| panic = "abort" |
There was a problem hiding this comment.
Hey @IdoKendo 👋
Thank you for the great work 😄 Can you please share some documentation of these three flags? Or explain what is the purpose of these three flags?
There was a problem hiding this comment.
There was a problem hiding this comment.
@IdoKendo , what are the other two here?
There was a problem hiding this comment.
- By default, Cargo instructs compilation units to be compiled and optimized in isolation. LTO instructs the linker to optimize at the link stage. This can, for example, remove dead code and often times reduces binary size.
- By default, when Rust code encounters a situation when it must call panic!(), it unwinds the stack and produces a helpful backtrace. The unwinding code, however, does require extra binary size. rustc can be instructed to abort immediately rather than unwind, which removes the need for this extra unwinding code.
ref: https://doc.rust-lang.org/cargo/reference/profiles.html#default-profiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces the .whl file size to 2.2MB on release mode. This is about 30% smaller than current build size which is 3.4MB - I have not seen any performance degradation or issues arise from these changes so it's a net gain by tweaking these values.