Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update terraform github.com/sparkfabrik/terraform-sparkfabrik-prometheus-stack to v4 #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 4, 2024

This PR contains the following updates:

Package Type Update Change
github.com/sparkfabrik/terraform-sparkfabrik-prometheus-stack module major 3.0.0 -> 4.0.0

Release Notes

sparkfabrik/terraform-sparkfabrik-prometheus-stack (github.com/sparkfabrik/terraform-sparkfabrik-prometheus-stack)

v4.0.0

Compare Source

Compare with previous version

⚠️ BREAKING CHANGES ⚠️

In the previous version, if the prometheus_adapter_chart_version variable was set, the module enabled the Prometheus Adapter installation. This behavior has been changed. Now, to enable the Prometheus Adapter installation, you must set the prometheus_adapter_enabled variable to true. The prometheus_adapter_chart_version variable is now optional and is used if you want to specify a different chart version from the default one. Remember that the shipped chart values are specific to the default chart version.

If you are not using the Prometheus Adapter (you do not specify the prometheus_adapter_chart_version variable in your configuration), you can safely ignore this breaking change.

If you receive the following error message during the upgrade:

cannot patch "kube-prometheus-stack-prometheus-node-exporter" with kind DaemonSet: DaemonSet.apps "kube-prometheus-stack-prometheus-node-exporter" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/instance":"kube-prometheus-stack", "app.kubernetes.io/name":"prometheus-node-exporter"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

you can delete the DaemonSet (kubectl delete daemonsets kube-prometheus-stack-prometheus-node-exporter) resource and apply the changes again. The helm release will recreate the DaemonSet resource with the correct selector. The only drawback is that you will lose the metrics collected by the DaemonSet during the downtime.

Added
  • Add the default versions for prometheus_stack_chart_version and prometheus_adapter_chart_version variables. These values indicate the default chart version to use and the reference to the shipped chart values.
  • Add the prometheus_adapter_enabled variable to enable or disable the Prometheus Adapter installation.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies label Jun 4, 2024
@renovate renovate bot force-pushed the renovate/github.com-sparkfabrik-terraform-sparkfabrik-prometheus-stack-4.x branch from b6f62d4 to 3e2725c Compare July 9, 2024 08:40
@renovate renovate bot force-pushed the renovate/github.com-sparkfabrik-terraform-sparkfabrik-prometheus-stack-4.x branch from 3e2725c to df1e389 Compare September 10, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants