Allow non-RFC 3986-compliant URLs #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knu
reviewed
Nov 1, 2023
|
|
||
| REGEXP = { | ||
| ABS_PATH: /\A[^?#]*\z/ | ||
| } |
There was a problem hiding this comment.
This constant does not seem to be used in any way.
| if uri.is_a?(URI::Generic) | ||
| uri | ||
| elsif uri = String.try_convert(uri) | ||
| parse(uri) |
There was a problem hiding this comment.
I think we should try the default URI.parse() first and then our custom parser only if it fails.
Comment on lines
+1
to
+4
| require 'singleton' | ||
|
|
||
| class HTTP::Cookie::URIParser | ||
| include Singleton |
There was a problem hiding this comment.
You don't need a class or instance for providing these methods. Make it a module and provide module functions.
Suggested change
| require 'singleton' | |
| class HTTP::Cookie::URIParser | |
| include Singleton | |
| module HTTP::Cookie::URIParser | |
| module_function |
| } | ||
|
|
||
| def parse(uri) | ||
| m = / |
There was a problem hiding this comment.
Using %r{…} will eliminate the need for escaping the slash character.
|
Yes, I believe it does. Thanks! |
|
@knu This solution solved some of the errors I saw but also some invalid URIs with curly braces in path segments. Would you be open to adding curly braces to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has objective as #44 but takes a different approach.
It avoids polymorphism. It still represents URLs as
URIinstances but uses a very liberal URL parser.