Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error if frames/channels are non-integers #565

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Better error if frames/channels are non-integers #565

merged 1 commit into from
Oct 15, 2024

Conversation

mgeier
Copy link
Member

@mgeier mgeier commented Oct 12, 2024

Resolves #564.

An eventual type error for dtype is not handled here, because I think the original error message is good enough:

TypeError: Cannot interpret ... as a data type

@mgeier mgeier mentioned this pull request Oct 12, 2024
Closed
288bb
288bb approved these changes Oct 14, 2024
View reviewed changes
Copy link

@288bb 288bb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, this will help all users of sounddevice identify errors when using sd.rec().

@mgeier mgeier merged commit f37a6ef into spatialaudio:master Oct 15, 2024
14 checks passed
@mgeier mgeier deleted the check-frames-channels-integer branch October 15, 2024 17:43
@mgeier
Copy link
Member Author

mgeier commented Oct 15, 2024

Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@288bb 288bb 288bb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mgeier @288bb