Escape ICS DESCRIPTION

spatie · Dec 11, 2022 · f632ac0 · f632ac0
1 parent 419b9f2
commit f632ac0
Show file tree

Hide file tree

Showing 9 changed files with 9 additions and 23 deletions.
diff --git a/src/Generators/Ics.php b/src/Generators/Ics.php
@@ -50,7 +50,7 @@ public function generate(Link $link): string
         }
 
         if ($link->description) {
-            $url[] = 'DESCRIPTION:'.strip_tags($link->description);
+            $url[] = 'DESCRIPTION:'.$this->escapeString(strip_tags($link->description));
         }
         if ($link->address) {
             $url[] = 'LOCATION:'.$this->escapeString($link->address);

diff --git a/...eratorTest__it_can_generate_a_description_is_html_code_event_link_with_allday_flag__1.txt b/...eratorTest__it_can_generate_a_description_is_html_code_event_link_with_allday_flag__1.txt
@@ -7,14 +7,7 @@ SUMMARY:Birthday Party +1
 DTSTAMP;TZID=UTC:20180201T090000
 DTSTART;TZID=UTC:20180201T090000
 DTEND;TZID=UTC:20180201T180000
-DESCRIPTION:With balloons, clowns and stuff
-Bring a dog, bring a frog.
-There will be line breaks on it.
-Project link calendar-links
-
-
-Thank you.
-
+DESCRIPTION:With balloons\, clowns and stuff\nBring a dog\, bring a frog.\nThere will be line breaks on it.\nProject link calendar-links\n\n\nThank you.\n
 LOCATION:Party Lane 1A\, 1337 Funtown
 END:VEVENT
 END:VCALENDAR
diff --git a/...erators/__snapshots__/IcsGeneratorTest__it_can_generate_a_multiple_days_event_link__1.txt b/...erators/__snapshots__/IcsGeneratorTest__it_can_generate_a_multiple_days_event_link__1.txt
@@ -7,8 +7,7 @@ SUMMARY:New Year
 DTSTAMP;TZID=UTC:20191231T230000
 DTSTART;TZID=UTC:20191231T230000
 DTEND;TZID=UTC:20200101T010000
-DESCRIPTION:With balloons, clowns and stuff
-Bring a dog, bring a frog
+DESCRIPTION:With balloons\, clowns and stuff\nBring a dog\, bring a frog
 LOCATION:Party Lane 1A\, 1337 Funtown
 END:VEVENT
 END:VCALENDAR
diff --git a/...ts__/IcsGeneratorTest__it_can_generate_a_multiple_days_event_link_with_allday_flag__1.txt b/...ts__/IcsGeneratorTest__it_can_generate_a_multiple_days_event_link_with_allday_flag__1.txt
@@ -7,8 +7,7 @@ SUMMARY:Birthday
 DTSTAMP;TZID=20180201
 DTSTART:20180201
 DURATION:P5D
-DESCRIPTION:With balloons, clowns and stuff
-Bring a dog, bring a frog
+DESCRIPTION:With balloons\, clowns and stuff\nBring a dog\, bring a frog
 LOCATION:Party Lane 1A\, 1337 Funtown
 END:VEVENT
 END:VCALENDAR
diff --git a/tests/Generators/__snapshots__/IcsGeneratorTest__it_can_generate_a_short_event_link__1.txt b/tests/Generators/__snapshots__/IcsGeneratorTest__it_can_generate_a_short_event_link__1.txt
@@ -7,8 +7,7 @@ SUMMARY:Birthday
 DTSTAMP;TZID=UTC:20180201T090000
 DTSTART;TZID=UTC:20180201T090000
 DTEND;TZID=UTC:20180201T180000
-DESCRIPTION:With balloons, clowns and stuff
-Bring a dog, bring a frog
+DESCRIPTION:With balloons\, clowns and stuff\nBring a dog\, bring a frog
 LOCATION:Party Lane 1A\, 1337 Funtown
 END:VEVENT
 END:VCALENDAR
diff --git a/...ors/__snapshots__/IcsGeneratorTest__it_can_generate_a_single_day_allday_event_link__1.txt b/...ors/__snapshots__/IcsGeneratorTest__it_can_generate_a_single_day_allday_event_link__1.txt
@@ -7,8 +7,7 @@ SUMMARY:Birthday
 DTSTAMP;TZID=20180201
 DTSTART:20180201
 DURATION:P1D
-DESCRIPTION:With balloons, clowns and stuff
-Bring a dog, bring a frog
+DESCRIPTION:With balloons\, clowns and stuff\nBring a dog\, bring a frog
 LOCATION:Party Lane 1A\, 1337 Funtown
 END:VEVENT
 END:VCALENDAR
diff --git a/...rators/__snapshots__/IcsGeneratorTest__it_can_generate_an_ics_link_with_custom_uid__1.txt b/...rators/__snapshots__/IcsGeneratorTest__it_can_generate_an_ics_link_with_custom_uid__1.txt
@@ -7,8 +7,7 @@ SUMMARY:Birthday
 DTSTAMP;TZID=UTC:20180201T090000
 DTSTART;TZID=UTC:20180201T090000
 DTEND;TZID=UTC:20180201T180000
-DESCRIPTION:With balloons, clowns and stuff
-Bring a dog, bring a frog
+DESCRIPTION:With balloons\, clowns and stuff\nBring a dog\, bring a frog
 LOCATION:Party Lane 1A\, 1337 Funtown
 END:VEVENT
 END:VCALENDAR
diff --git a/tests/Generators/__snapshots__/IcsGeneratorTest__it_has_a_product_dtstamp__1.txt b/tests/Generators/__snapshots__/IcsGeneratorTest__it_has_a_product_dtstamp__1.txt
@@ -7,8 +7,7 @@ SUMMARY:Birthday
 DTSTAMP;TZID=UTC:20180201T090000
 DTSTART;TZID=UTC:20180201T090000
 DTEND;TZID=UTC:20180201T180000
-DESCRIPTION:With balloons, clowns and stuff
-Bring a dog, bring a frog
+DESCRIPTION:With balloons\, clowns and stuff\nBring a dog\, bring a frog
 LOCATION:Party Lane 1A\, 1337 Funtown
 END:VEVENT
 END:VCALENDAR
diff --git a/tests/Generators/__snapshots__/IcsGeneratorTest__it_has_a_product_id__1.txt b/tests/Generators/__snapshots__/IcsGeneratorTest__it_has_a_product_id__1.txt
@@ -7,8 +7,7 @@ SUMMARY:Birthday
 DTSTAMP;TZID=UTC:20180201T090000
 DTSTART;TZID=UTC:20180201T090000
 DTEND;TZID=UTC:20180201T180000
-DESCRIPTION:With balloons, clowns and stuff
-Bring a dog, bring a frog
+DESCRIPTION:With balloons\, clowns and stuff\nBring a dog\, bring a frog
 LOCATION:Party Lane 1A\, 1337 Funtown
 END:VEVENT
 END:VCALENDAR