Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URL customisations for Google, Outlook and Yahoo #191

Merged
merged 2 commits into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/Generators/BaseOutlook.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

/**
* @see https://github.com/InteractionDesignFoundation/add-event-to-calendar-docs/blob/master/services/outlook-web.md
* @psalm-type OutlookUrlParameters = array<string, scalar|null>
*/
abstract class BaseOutlook implements Generator
{
Expand All @@ -17,6 +18,15 @@ abstract class BaseOutlook implements Generator
/** @var string {@see https://www.php.net/manual/en/function.date.php} */
protected $dateTimeFormat = 'Y-m-d\TH:i:s\Z';

/** @psalm-var OutlookUrlParameters */
protected array $urlParameters = [];

/** @psalm-param OutlookUrlParameters $urlParameters */
public function __construct(array $urlParameters = [])
{
$this->urlParameters = $urlParameters;
}

/** Get base URL for links. */
abstract public function baseUrl(): string;

Expand Down Expand Up @@ -47,6 +57,10 @@ public function generate(Link $link): string
$url .= '&location='.$this->sanitizeString($link->address);
}

foreach ($this->urlParameters as $key => $value) {
$url .= '&'.urlencode($key).(in_array($value, [null, ''], true) ? '' : '='.$this->sanitizeString((string) $value));
}

return $url;
}

Expand Down
14 changes: 14 additions & 0 deletions src/Generators/Google.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

/**
* @see https://github.com/InteractionDesignFoundation/add-event-to-calendar-docs/blob/master/services/google.md
* @psalm-type GoogleUrlParameters = array<string, scalar|null>
*/
class Google implements Generator
{
Expand All @@ -16,6 +17,15 @@ class Google implements Generator
/** @var string */
protected $dateTimeFormat = 'Ymd\THis\Z';

/** @psalm-var GoogleUrlParameters */
protected array $urlParameters = [];

/** @psalm-param GoogleUrlParameters $urlParameters */
public function __construct(array $urlParameters = [])
{
$this->urlParameters = $urlParameters;
}

/** {@inheritDoc} */
public function generate(Link $link): string
{
Expand Down Expand Up @@ -44,6 +54,10 @@ public function generate(Link $link): string
$url .= '&location='.urlencode($link->address);
}

foreach ($this->urlParameters as $key => $value) {
$url .= '&'.urlencode($key).(in_array($value, [null, ''], true) ? '' : '='.urlencode((string) $value));
}

return $url;
}
}
2 changes: 1 addition & 1 deletion src/Generators/Ics.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Ics implements Generator
/** @var string */
protected $dateTimeFormat = 'Ymd\THis\Z';

/** @var IcsOptions */
/** @psalm-var IcsOptions */
protected $options = [];

/** @var array{format?: self::FORMAT_*} */
Expand Down
15 changes: 15 additions & 0 deletions src/Generators/Yahoo.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,25 @@

/**
* @see https://github.com/InteractionDesignFoundation/add-event-to-calendar-docs/blob/master/services/yahoo.md
* @psalm-type YahooUrlParameters = array<string, scalar|null>
*/
class Yahoo implements Generator
{
/** @var string {@see https://www.php.net/manual/en/function.date.php} */
protected $dateFormat = 'Ymd';

/** @var string */
protected $dateTimeFormat = 'Ymd\THis\Z';

/** @psalm-var YahooUrlParameters */
protected array $urlParameters = [];

/** @psalm-param YahooUrlParameters $urlParameters */
public function __construct(array $urlParameters = [])
{
$this->urlParameters = $urlParameters;
}

/** {@inheritDoc} */
public function generate(Link $link): string
{
Expand Down Expand Up @@ -44,6 +55,10 @@ public function generate(Link $link): string
$url .= '&in_loc='.$this->sanitizeText($link->address);
}

foreach ($this->urlParameters as $key => $value) {
$url .= '&'.urlencode($key).(in_array($value, [null, ''], true) ? '' : '='.$this->sanitizeText((string) $value));
}

return $url;
}

Expand Down
23 changes: 15 additions & 8 deletions src/Link.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
* @property-read string $address
* @property-read bool $allDay
* @psalm-import-type IcsOptions from \Spatie\CalendarLinks\Generators\Ics
* @psalm-import-type GoogleUrlParameters from \Spatie\CalendarLinks\Generators\Google
* @psalm-import-type YahooUrlParameters from \Spatie\CalendarLinks\Generators\Yahoo
* @psalm-import-type OutlookUrlParameters from \Spatie\CalendarLinks\Generators\BaseOutlook
*/
class Link
{
Expand Down Expand Up @@ -123,9 +126,10 @@ public function formatWith(Generator $generator): string
return $generator->generate($this);
}

public function google(): string
/** @psalm-param GoogleUrlParameters $urlParameters */
public function google(array $urlParameters = []): string
{
return $this->formatWith(new Google());
return $this->formatWith(new Google($urlParameters));
}

/**
Expand All @@ -139,19 +143,22 @@ public function ics(array $options = [], array $presentationOptions = []): strin
return $this->formatWith(new Ics($options, $presentationOptions));
}

public function yahoo(): string
/** @psalm-param YahooUrlParameters $urlParameters */
public function yahoo(array $urlParameters = []): string
{
return $this->formatWith(new Yahoo());
return $this->formatWith(new Yahoo($urlParameters));
}

public function webOutlook(): string
/** @psalm-param OutlookUrlParameters $urlParameters */
public function webOutlook(array $urlParameters = []): string
{
return $this->formatWith(new WebOutlook());
return $this->formatWith(new WebOutlook($urlParameters));
}

public function webOffice(): string
/** @psalm-param OutlookUrlParameters $urlParameters */
public function webOffice(array $urlParameters = []): string
{
return $this->formatWith(new WebOffice());
return $this->formatWith(new WebOffice($urlParameters));
}

public function __get($property)
Expand Down
8 changes: 8 additions & 0 deletions tests/Generators/GoogleGeneratorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,12 @@ public function it_correctly_generates_all_day_events_by_dates(): void
$this->generator()->generate($this->createEventMultipleDaysViaStartEndWithTimezoneLink())
);
}

/** @test */
public function it_can_generate_an_url_with_custom_parameters(): void
{
$link = $this->createShortEventLink();

$this->assertMatchesSnapshot($link->google(['recur' => 'RRULE:FREQ=DAILY']));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh google does support re-occuring!
Did you find documentation for the params?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My company also maintains docs for services like Google calendar: https://github.com/InteractionDesignFoundation/add-event-to-calendar-docs/blob/master/services/google.md

Links to these docs you can find on PHPDoc (class-level docs on generators)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh awesome. Didn't realise google support recurring rules. Shame other providers dont

}
}
8 changes: 8 additions & 0 deletions tests/Generators/WebOfficeGeneratorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,12 @@ protected function linkMethodName(): string
{
return 'webOffice';
}

/** @test */
public function it_can_generate_an_url_with_custom_parameters(): void
{
$link = $this->createShortEventLink();

$this->assertMatchesSnapshot($link->webOffice(['online' => 1]));
}
}
8 changes: 8 additions & 0 deletions tests/Generators/WebOutlookGeneratorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,12 @@ protected function linkMethodName(): string
{
return 'webOutlook';
}

/** @test */
public function it_can_generate_an_url_with_custom_parameters(): void
{
$link = $this->createShortEventLink();

$this->assertMatchesSnapshot($link->webOutlook(['online' => 1]));
}
}
8 changes: 8 additions & 0 deletions tests/Generators/YahooGeneratorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,12 @@ public function it_can_generate_a_yahoo_link_for_long_multiple_days_event(): voi

$this->assertMatchesSnapshot($link->yahoo());
}

/** @test */
public function it_can_generate_an_url_with_custom_parameters(): void
{
$link = $this->createShortEventLink();

$this->assertMatchesSnapshot($link->yahoo(['uid' => '750e0c92aa33a7382460a280c2dfb8e6', 'msngr' => null]));
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
https://calendar.google.com/calendar/render?action=TEMPLATE&dates=20180201T090000Z/20180201T180000Z&ctz=UTC&text=Birthday&details=With+balloons%2C+clowns+and+stuff%0ABring+a+dog%2C+bring+a+frog&location=Party+Lane+1A%2C+1337+Funtown&recur=RRULE%3AFREQ%3DDAILY
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
https://outlook.office.com/calendar/deeplink/compose?path=/calendar/action/compose&rru=addevent&startdt=2018-02-01T09:00:00Z&enddt=2018-02-01T18:00:00Z&subject=Birthday&body=With%20balloons%2C%20clowns%20and%20stuff%0ABring%20a%20dog%2C%20bring%20a%20frog&location=Party%20Lane%201A%2C%201337%20Funtown&online=1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
https://outlook.live.com/calendar/action/compose?path=/calendar/action/compose&rru=addevent&startdt=2018-02-01T09:00:00Z&enddt=2018-02-01T18:00:00Z&subject=Birthday&body=With%20balloons%2C%20clowns%20and%20stuff%0ABring%20a%20dog%2C%20bring%20a%20frog&location=Party%20Lane%201A%2C%201337%20Funtown&online=1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
https://calendar.yahoo.com/?v=60&view=d&type=20&ST=20180201T090000Z&ET=20180201T180000Z&TITLE=Birthday&DESC=With%20balloons%2C%20clowns%20and%20stuff%0ABring%20a%20dog%2C%20bring%20a%20frog&in_loc=Party%20Lane%201A%2C%201337%20Funtown&uid=750e0c92aa33a7382460a280c2dfb8e6&msngr
Loading