Merge pull request #99 from mogic-le/geo-float

Fix GEO coordinates on locale with comma as decimal separator
spatie · Oct 26, 2022 · 128d8fe · 128d8fe
2 parents 789422f + bbd3551
commit 128d8fe
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Properties/CoordinatesProperty.php b/src/Properties/CoordinatesProperty.php
@@ -22,7 +22,7 @@ public function __construct(string $name, float $lat, float $lng)
 
     public function getValue(): string
     {
-        return "{$this->lat};{$this->lng}";
+        return json_encode($this->lat) . ';' . json_encode($this->lng);
     }
 
     public function getOriginalValue(): array

diff --git a/tests/Properties/CoordinatesPropertyTest.php b/tests/Properties/CoordinatesPropertyTest.php
@@ -1,5 +1,7 @@
 <?php
 
+namespace Spatie\IcalendarGenerator\Tests\Properties;
+
 use Spatie\IcalendarGenerator\Properties\CoordinatesProperty;
 use Spatie\IcalendarGenerator\Tests\PropertyExpectation;
 
@@ -11,3 +13,13 @@
         ->expectOutput('10.5;20.5')
         ->expectValue(['lat' => 10.5, 'lng' => 20.5]);
 });
+
+test('it_has_dot_as_decimal_point', function () {
+    setlocale(LC_ALL, 'de_DE.UTF-8');
+    $propertyType = new CoordinatesProperty('GEO', 10.5, 20.5);
+
+    PropertyExpectation::create($propertyType)
+        ->expectName('GEO')
+        ->expectOutput('10.5;20.5')
+        ->expectValue(['lat' => 10.5, 'lng' => 20.5]);
+});