Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dtend for full day events should be on the next day at midnight #128

Merged
merged 1 commit into from
May 8, 2024

Conversation

joostdebruijn
Copy link
Contributor

The standard/RFC states: "The "DTEND" property for a "VEVENT" calendar component specifies the non-inclusive end of the event.". The specified end date is therefore not part of the event period. For example, in Thunderbird, Outlook and Owncloud, the events are therefore displayed one day shorter than they actually are. One-day full day events are shown only at midnight.

This PR sets the DTEND for full events at the next day, midnight to fix this.

@rubenvanassche
Copy link
Member

Thanks!

@rubenvanassche rubenvanassche merged commit 60bb7fd into spatie:main May 8, 2024
9 checks passed
@joostdebruijn joostdebruijn deleted the joost/fix-dtendfullday branch May 16, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants