Change bin2hex for ParagonIE\ConstantTime\Hex::encode

Signed-off-by: Pitos <[email protected]>
spatie · Aug 19, 2023 · cb0fa5c · cb0fa5c
1 parent c3fc116
commit cb0fa5c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/Commands/GenerateKeyCommand.php b/src/Commands/GenerateKeyCommand.php
@@ -7,6 +7,7 @@
 use Symfony\Component\Console\Attribute\AsCommand;
 use ParagonIE\ConstantTime\{
     Base64UrlSafe,
+    Hex
 };
 
 #[AsCommand(name: 'ciphersweet:generate-key')]
@@ -65,8 +66,7 @@ protected function generateRandomKey(): string
         $randomBytes = $this->generateRandomBytes();
         if ($this->option('base64'))
             return Base64UrlSafe::encode($randomBytes);
-
-        return bin2hex($randomBytes);
+        return Hex::encode($randomBytes);
     }
 
     /**

diff --git a/tests/CipherSweetTest.php b/tests/CipherSweetTest.php
@@ -9,7 +9,6 @@
 
 use Spatie\LaravelCipherSweet\Commands\EncryptCommand;
 use Spatie\LaravelCipherSweet\Tests\TestClasses\User;
-use Spatie\LaravelCipherSweet\Commands\GenerateKeyCommand;
 
 beforeEach(function () {
     $this->user = User::create([
@@ -116,6 +115,11 @@
     User::first(); // Shouldn't throw an exception.
 });
 
+it('can generate key in hex', function(){
+    $this->artisan('ciphersweet:generate-key --show')
+     ->assertSuccessful();
+});
+
 it('can generate key in base64', function(){
     $this->artisan('ciphersweet:generate-key --show --base64')
      ->assertSuccessful();