New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type for CreationContextFactory::alwaysValidate #925

Open

sanfair wants to merge 1 commit into spatie:main from sanfair:always-validate-lose-generic-type

sanfair commented Jan 9, 2025

Improve type for \Spatie\LaravelData\Support\Creation\CreationContextFactory::alwaysValidate() function

Without explicitly returning $this type, the current definition loses generic information.
https://phpstan.org/r/1b074136-57c7-4f4e-a2ec-34fd1e9bfd91

  $factory = MentionableRecord::factory()->alwaysValidate();
  \PHPStan\dumpType($factory);

Current state

Dumped type: Spatie\LaravelData\Support\Creation\CreationContextFactory

After the change

Dumped type: Spatie\LaravelData\Support\Creation\CreationContextFactory<App\Dto\MentionableRecord>


          Improve type for CreationContextFactory::alwaysValidate

e2eca74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet