Update HasTags.php #507
Closed
Update HasTags.php #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixed an issue I encountered when returning tags with a type. $this->tags was Null. Fetching the tags and filtering them resolved the issue.
|
Also in reference #[#279] |
|
Mmmm, strange, I'm not inclined to merge this, as it would have a performance implication. A query would always be performed with the new code. Using the old code, the query would only be performed once. |
|
I understand - but the old code also fails. I'm going to put a screenshot here just incase someone can make a better fix. 
|
|
@Sindoweb check if you are casting "tags" as array in your model (or have a tag function/property in your model that conflicts with the package)! cc @freekmurze |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixed an issue I encountered when returning tags with a type. $this->tags was Null. Fetching the tags (instead of relying on the variable) and filtering them resolved the (read: my) issue.