Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
…h tree properties as root and tree size
…hod is placed in an abstract class. Clearing some todos from labels. Corrected the AVLTree.kt file by adding the missing maxDescendantForAVL(AVLTreeNode<K, V>) AVLTree method to the class. Added TODO marks in the BSTree file defining the implementation of the insert & remove methods
Add subdirrectory with files of intreface SearchTreeIterator and enum of orders to iterate on search trees and class of BinarySearchTreeIterator to iterate on BST and other implementations of it
Fix invalid name of last pushed commit such as <feat(Addding iterators):>bash: строка 1: q: команда не найдена
Add implementation of insert method of SearchTree at class RBTree and add new method at SearchTree interface with name insertIfAbsent
…ot build) BREAKING CHANGE: implement methods for an AbstractBSTree, refactor AbstractBSTree, BSTree, SearchTree, SearchTreeNode, AbstractBSTreeNode, BSTreeNode. Add the pattern of ignoring to .gitignore
…d enter to .gitignore
…ith AbstractBSTree. Add implementation of the remove method at RBTree. Remove unnecessary interface of SearchTreeIterator. Update BinarySearchTreeIterator by implementing Iterator interface. Update ReadMe by adding info about finished trees
…examples of using it
…t on the github of root readme by removing it
Docs integrated on IterationOrders.kt, BinarySearchTreeIterator.kt, RBTree.kt, RBTreeNode.kt and Utils.kt
…as public. A child property is closed. Modify tests after feedback. Add whitespace in yml-script
…node with red color type and null children
Merge branch test to main
… with python-script and update yml-script for it
…formation of ParametrizedTests by changing display name
…orkflow yml-script
…f displaying test result information
… Disable depentancy task jacocoTestReport on task test. Change colorize of test coverage information and add endline at file text_colorize.py
…display_test_result
…accordingly yml-script to run updated python-script correctly
Merge branches test and main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @IliaSuponeff @Friend-zva @RodionovMaxim05