connection: ignore window updates after end stream

spdy-http2 · Feb 9, 2017 · da15e89 · da15e89
1 parent faa0e09
commit da15e89
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/lib/spdy-transport/connection.js b/lib/spdy-transport/connection.js
@@ -307,6 +307,10 @@ Connection.prototype._handleFrame = function _handleFrame (frame) {
       // Other side should destroy the stream upon receiving GOAWAY
       if (this._isGoaway(frame.id)) { return }
 
+      // Ignore WINDOW_UPDATE frames from closed streams
+      if (frame.type === 'WINDOW_UPDATE' &&
+          frame.id <= state.stream.lastId.received) { return }
+
       state.debug('id=0 stream=%d not found', frame.id)
       state.framer.rstFrame({ id: frame.id, code: 'INVALID_STREAM' })
       return

diff --git a/test/both/transport/connection-test.js b/test/both/transport/connection-test.js
@@ -294,6 +294,30 @@ describe('Transport/Connection', function () {
       })
     })
 
+    it('should ignore WINDOW_UPDATE frame after END_STREAM', function (done) {
+      client.request({
+        path: '/hello'
+      }, function (err, stream) {
+        assert(!err)
+
+        stream.resume()
+
+        stream.once('close', function () {
+          client.on('frame', function (frame) {
+            assert(!(frame.type === 'RST' && frame.id === 1))
+          })
+
+          client._spdyState.framer.windowUpdateFrame({
+            id: stream.id,
+            delta: 1
+          }, function (err) {
+            assert(!err)
+            setTimeout(done, 10)
+          })
+        })
+      })
+    })
+
     it('should use last received id when killing streams', function (done) {
       var waiting = 2
       function next () {