Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ageCitations #5341

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

Add ageCitations #5341

wants to merge 1 commit into from

Conversation

CarolineDenis
Copy link
Contributor

Fixes #5340

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • verify age citations (for both relative and absolute) are present in the data-model tab
  • verify you can add it to view def

@CarolineDenis CarolineDenis added this to the 7.9.8 milestone Oct 23, 2024
@CarolineDenis
Copy link
Contributor Author

CarolineDenis commented Oct 23, 2024

TODO:

  • rename migration once the other ones in 9.8 are merged in prod

Just a reminder: when you pull production and rename the migration later, make sure to regenerate the frontend types as prod will have new frontend types at that point.

Copy link
Contributor

@sharadsw sharadsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a reminder: when you pull production and rename the migration later, make sure to regenerate the frontend types as prod will have new frontend types at that point.

@CarolineDenis CarolineDenis requested a review from a team October 23, 2024 15:31
@CarolineDenis CarolineDenis marked this pull request as ready for review October 23, 2024 15:31
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • verify age citations (for both relative and absolute) are present in the data-model tab
  • verify you can add it to view def

The age citations relationships are not present in the schema config for absolute and relative age, however, in the age citations you can see the absolute or relative age relationship. I know this wasn't a check but I assume it should be present in the schema config if it is present in the data model and one side of the relationship shows it.

chrome_rG2tENsj7d.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Dev Attention Needed
Development

Successfully merging this pull request may close these issues.

Relative and Absolute Age do not link to corresponding citation tables in the data model
3 participants