Orbit Around Cursor #3796
Open
Orbit Around Cursor #3796
+335
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orbiting around mouse cursor now works correctly with an orthographic projection as well as when toggling between orthographic and perspective. Disabled WASD navigation for now. SmoothOrbitControls now has protected members instead of private allowing extension Documented the important parts of the pivotal navigation code
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
Additionally fixed an issue where changing the orbit pivot would trigger a hard render, adding the unneeded noise of AO re-convergence
|
📸 Preview service has generated an image. |
…tions caused by the introduction on the pivotal CS. Pivot sphere now shows only on orbit
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
- When clicking outside of the model, oribitig will switch to polar and use the last computed origin (which is still going to be based on the last pivot point) Made the pivot sphere speckle blue The pivot sphere now only shows when clicking on objects, when clicking outside of the model it will not show
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
This PR implements orbiting around cursor for
SmoothOrbitControls. This features can be enabled via the optionorbitAroundCursor, and it's currently set totrueby default.Additionally, we've added
showOrbitPointwhich shows the pivot/origin point while orbiting.More implementation details here
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References