fix(Navisworks): CNX-889 Prevent unnecessary "Save Changes" prompts in Navisworks

[jsdbroughton]

Prevent unnecessary "Save Changes" prompts in Navisworks

Issue

Users were prompted to save changes when closing Navisworks, even when no actual modifications had been made to the model. This was occurring because database operations were unnecessarily marking the document as modified.

Root Cause Analysis

Investigation revealed several causes:

1. Using DatabaseChangedAction.Reset in transactions was marking the document as modified, even for read-only operations
2. Creating transactions to check table existence was triggering the document's dirty state
3. The table existence check was being performed with a transaction unnecessarily, even for read operations

Changes

1. Split database operations into discrete functions:

   • DoesTableExist() - Pure read operation without transactions
   • CreateTable() - Only uses transaction when creating the table

2. Modified database operations to minimize transactions:

   • Removed transactions entirely from read operations
   • Only use transactions when writing data
   • Changed DatabaseChangedAction.Reset to DatabaseChangedAction.Edited when modifications are needed

3. Optimized state retrieval:

   • Removed unnecessary transaction from RetrieveStateFromDatabase()
   • Simplified table existence checking
   • Added early returns to avoid unnecessary operations

4. Added state comparison:

   • Track the last saved state to avoid redundant saves
   • Only write to the database when the state changes

Impact

• Users will no longer see save prompts unless actual changes have been made
• Improved performance by reducing unnecessary database operations
• Maintained all existing functionality while reducing false "dirty" states

Technical Details

The key discovery was that even read-only database operations using DatabaseChangedAction.Reset marked the document as modified. We now avoid transactions altogether for read operations and only use them with DatabaseChangedAction.Edited when making changes.

Testing Notes

Areas verified:

• Opening and closing documents without changes should not prompt for save
• Making actual changes should still prompt for save
• Database state persistence should continue working as expected
• State comparison should prevent unnecessary saves

[linear]

CNX-889 User is prompted to save file on close even with no changes made

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.15%. Comparing base (ba0cdd3) to head (4c17ca3).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@          Coverage Diff          @@
##             dev    #491   +/-   ##
=====================================
  Coverage   9.15%   9.15%           
=====================================
  Files        228     228           
  Lines       4306    4306           
  Branches     542     542           
=====================================
  Hits         394     394           
  Misses      3896    3896           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.