retry result can be null so handle it better (#142)

Co-authored-by: Alan Rynne <[email protected]>
specklesystems · Oct 17, 2024 · 3c783b3 · 3c783b3
1 parent 8f8be74
commit 3c783b3
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/Speckle.Sdk/Helpers/SpeckleHttpClientHandler.cs b/src/Speckle.Sdk/Helpers/SpeckleHttpClientHandler.cs
@@ -52,12 +52,16 @@ CancellationToken cancellationToken
         .ConfigureAwait(false);
       context.TryGetValue("retryCount", out var retryCount);
       activity?.SetTag("retryCount", retryCount);
-      activity?.SetStatus(
-        policyResult.Result.IsSuccessStatusCode ? SdkActivityStatusCode.Ok : SdkActivityStatusCode.Error
-      );
       if (policyResult.FinalException != null)
       {
         activity?.RecordException(policyResult.FinalException);
+        activity?.SetStatus(SdkActivityStatusCode.Error);
+      }
+      else
+      {
+        activity?.SetStatus(
+          policyResult.Result.IsSuccessStatusCode ? SdkActivityStatusCode.Ok : SdkActivityStatusCode.Error
+        );
       }
 
       if (policyResult.Outcome == OutcomeType.Successful)