feat(v-3): QGIS essentials #369
Conversation
There was a problem hiding this comment.
I went a bit too detailed, but hopefully we won't need to touch these again!
Some other comments not related to this specific commit, but related to the new objects:
- Point class "distance_to" ignores Point units (extra test can reveal it). Also a problem in C#
- Line method "from_coords" doesn't exist in C#
| return result | ||
|
|
||
| @classmethod | ||
| def from_list(cls, coords: List[float], units: str | Units) -> "Polyline": |
There was a problem hiding this comment.
if we follow C# methods, should we assume units are passed as the last element in the list (without keyword)? Same for Line
There was a problem hiding this comment.
the keywords are required for the class definition but not in the classmethods. So, for classmethods, yes.
There was a problem hiding this comment.
I decided to keep units as a seperate argument to be able to compatible with all the classes.
|
Formatting PR (you can ignore it and format yourself after changes, if you prefer): #370 |
Fixed. |
adds QGIS essentials.
Geometry:
Interface:
Proxies: