Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added line decoration renderer. #7

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

mkrueger
Copy link
Contributor

I use the line decoration renderer to add preview to completion items.

For example:
grafik

This shows the preview of "it" when pressing tab the completion will extend the word to "exit".

@mkrueger
Copy link
Contributor Author

@patriksvensson any feedback for that one?

@patriksvensson
Copy link
Contributor

@mkrueger Sorry, I didn't realize this was an extension point, so I was waiting for the implementation. Looks good to me.

@patriksvensson patriksvensson merged commit 7683859 into spectreconsole:main Jun 24, 2024
2 checks passed
@mkrueger
Copy link
Contributor Author

thanks - y my completion implementation is tied to the cmd line parser I use - it completes the syntax tree. Not sure if it's really worth providing an API for that. The basic thing is about ~150 LOC.
(without the parser - just the completion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants