-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_liquids_at function and small stuff #392
Conversation
…d ENTITY_MASK enum in C++
Btw. I'm still trying to figure out why would anyone want to know number of liquid entity/particles in a tile? |
The array is how the game mostly checks for liquid collisions (eg. |
This is be ready for review/merge now |
Hmmm now that i think about this, instead of using |
It would have been better months ago when I asked about it... but well that makes sense |
8222d82
to
ad8a42a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good
last note: in get_liquids_at
you didn't specify the literal values as floats, so the math is done with doubles
Not a big deal, probably done many times all over the API anyway
oh, you're right... I'm pretty perfectionist so I'll fix that anyway, it's just adding an |
I added the
ENTITY_MASK
enum, I didn't if name itMASK
because sounds too much of a generic name, but if someone thinks it's fine then I'll change it