Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity vtable fixes and new stuff #397

Merged
merged 28 commits into from
Dec 27, 2024
Merged

Entity vtable fixes and new stuff #397

merged 28 commits into from
Dec 27, 2024

Conversation

Mr-Auto
Copy link
Contributor

@Mr-Auto Mr-Auto commented Sep 11, 2024

No description provided.

Mr-Auto added 2 commits August 25, 2024 14:51
@Mr-Auto
fix some virtual functions, add missing parameters etc.
0626e90
@Mr-Auto
look thru entity virtual functions to understand them better, fix som…
264b3de 
…e, add missing parameters, make the vtable hooks not require giving the full signature, instead you can point to the function pointer. Fix auto doc (again)
Mr-Auto
Mr-Auto commented Sep 11, 2024
View reviewed changes
src/game_api/vtable_hook.hpp Outdated Show resolved Hide resolved
Mr-Auto
Mr-Auto commented Sep 12, 2024
View reviewed changes
src/game_api/entity.cpp Outdated Show resolved Hide resolved
@Mr-Auto
add SOUNDID alias, add function to convert from it to VANILLA_SOUND…
8c1a691 
… and vice versa. Some comments fix, clean up Entity file a little,expose some more stuff
@Mr-Auto
add and improve entity attach/detach
edd94cb
@Mr-Auto
fix invalidating iterator in remove_spawn
5a09f69
@Mr-Auto
fix Backpack subclass in lua, add more hookable functions to lua, tes…
665428d 
…t them etc. some comments and name changes, filter out bad pointers in vtable_sizes generated by info_dump
@Mr-Auto
typo
cf38c6a
@Mr-Auto Mr-Auto marked this pull request as ready for review November 16, 2024 12:38
SereneRuby12
SereneRuby12 reviewed Dec 7, 2024
View reviewed changes
Copy link
Contributor

@SereneRuby12 SereneRuby12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of it is great! Just some small things to fix

src/game_api/entities_items.hpp Outdated Show resolved Hide resolved
src/game_api/entities_monsters.hpp Outdated Show resolved Hide resolved
src/game_api/movable.hpp Show resolved Hide resolved
src/game_api/entities_mounts.hpp Outdated Show resolved Hide resolved
src/game_api/script/usertypes/vtables_lua.cpp Outdated Show resolved Hide resolved
src/game_api/script/usertypes/vtables_lua.cpp Show resolved Hide resolved
src/game_api/script/usertypes/entities_items_lua.cpp Show resolved Hide resolved
@Mr-Auto
rename pickup to give_powerup and expose it, fix comments for vta…
380de08 
…ble function that have different name for hook vs function itself, some comments here and there
SereneRuby12
SereneRuby12 approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@SereneRuby12 SereneRuby12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! (finally)

@Mr-Auto Mr-Auto merged commit 870bdf2 into spelunky-fyi:main Dec 27, 2024
10 checks passed
@Mr-Auto Mr-Auto deleted the virtuals branch December 28, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dregu Dregu Dregu left review comments

@SereneRuby12 SereneRuby12 SereneRuby12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mr-Auto @Dregu @SereneRuby12