Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow absolute paths in BasePathFs when prefix is "" on windows #420

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allow absolute paths in BasePathFs when prefix is "" on windows #420

wants to merge 2 commits into from

Conversation

DenKoren
Copy link

@DenKoren DenKoren commented Mar 25, 2024 •
edited
Loading

As a special case, it is OK to allow absolute paths access when the BasePathFs.path is empty.
Sometimes we need to provide access to full FS through BasePathFs type for code simplicity (to pass it to the functions, that want BasePathFs specific type, not just afero.FS interface).

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenKoren @CLAassistant