Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: window management #23

Merged
merged 2 commits into from
Nov 27, 2024
Merged

refactor: window management #23

merged 2 commits into from
Nov 27, 2024

Conversation

folke
Copy link
Contributor

@folke folke commented Nov 27, 2024

This PR builds further on the stylua PR:

  • fixes issues with :fclose!, and other ways, where smear windows could become invalid
  • it also uses the correct methods to set window/buffer options locally and without using deprecated APIs

@folke
Copy link
Contributor Author

folke commented Nov 27, 2024

This PR is actually not a lof of changes, but it looks off because that stylua PR is not merged yet :)

These are the real changes: 42080c1

@folke
Copy link
Contributor Author

folke commented Nov 27, 2024

rebased on main

Copy link
Owner

@sphamba sphamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work! I left a few questions

lua/smear_cursor/draw.lua Outdated Show resolved Hide resolved
lua/smear_cursor/draw.lua Show resolved Hide resolved
lua/smear_cursor/draw.lua Show resolved Hide resolved
@sphamba
Copy link
Owner

sphamba commented Nov 27, 2024

Perfect, I'm very pleased to have you on this project 😀

@sphamba sphamba merged commit eb8617f into sphamba:main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants