config: configure notifications to default off #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this extension has evolved over the years, the option `confluence_disable_notifications` was introduced to help suppress multiple notifications generated from publishing events. At the time of introduction, the feature was not enabled by default since it did result in changing page requests made and there was not an immediate desire to change the default state of things. Consider the common application of this extension, most users may not expect notifications to be generated for automated publish events. To make things easier for installations, we are changing the default mode of this extension to suppress page notifications. Users who prefer to have notification events generated are now recommended to explicitly configure the option. Signed-off-by: James Knight <[email protected]>
The option `confluence_disable_notifications` is now enabled by default. Updating the documentation to reflect this. Signed-off-by: James Knight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this extension has evolved over the years, the option
confluence_disable_notificationswas introduced to help suppress multiple notifications generated from publishing events. At the time of introduction, the feature was not enabled by default since it did result in changing page requests made and there was not an immediate desire to change the default state of things.Consider the common application of this extension, most users may not expect notifications to be generated for automated publish events. To make things easier for installations, we are changing the default mode of this extension to suppress page notifications. Users who prefer to have notification events generated are now recommended to explicitly configure the option.