Do not throw in parse_tag_file if the mappings is a single Entry instead of a FunctionList
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sea-bass
changed the title
parse_tag_file if the mappings is a single Entry instead of a FunctionList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a build error with the https://github.com/moveit/moveit2_tutorials repo and found that the
parse_tag_file()had a mappings dictionary that expected entities to map toFunctionListobjects, but many of them wereEntryobjects that could straightforwardly be packaged up into aFunctionListinstead of throwing an exception.I have no idea if this is correct, but it fixed the issue for me!