This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
Parametrize probes #310
Merged
Parametrize probes #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariusz Sabath <[email protected]>
kfox1111
reviewed
May 23, 2023
Signed-off-by: Mariusz Sabath <[email protected]>
mrsabath
requested review from
marcofranssen,
developer-guy,
dfeldman,
faisal-memon and
edwbuck
as code owners
Signed-off-by: Mariusz Sabath <[email protected]>
marcofranssen
added a commit
that referenced
this pull request
May 30, 2023
* d83d6a8 Emergency patch for Tornjak Frontend (#319) * ed172e4 Bump k8s versions to latest patches (#317) * 0562946 Removed pull_request edited event from ci workflow (#318) * 3cb55df Allow for having no registry specified (#312) * 1247b68 Parametrize probes (#310) Signed-off-by: Marco Franssen <[email protected]>
marcofranssen
added a commit
that referenced
this pull request
May 30, 2023
* d83d6a8 Emergency patch for Tornjak Frontend (#319) * ed172e4 Bump k8s versions to latest patches (#317) * 0562946 Removed pull_request edited event from ci workflow (#318) * 3cb55df Allow for having no registry specified (#312) * 1247b68 Parametrize probes (#310) Signed-off-by: Marco Franssen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #307 by parametrizing Probes and moving them to values.yaml